WebUI: Close cr-action-menu on popstate event.

WebUI: Close cr-action-menu on popstate event.

Without this the modal dialog stays open (even though not visible), blocking any
interaction with the underlying page.

BUG=681795
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2708863004
Cr-Commit-Position: refs/heads/master@{#452363}
Committed: https://chromium.googlesource.com/chromium/src/+/f76cfdd6f9737c1d982d3ab065bac4e58a1d8ff0

[dpapad, 2017-02-21 22:23:47]

Description was changed from

==========
WebUI: Close cr-action-menu on popstate event.

Without this the modal dialog stays open (even though not visible), blocking any
interaction with the underlying page.

BUG=681795
==========

to

==========
WebUI: Close cr-action-menu on popstate event.

Without this the modal dialog stays open (even though not visible), blocking any
interaction with the underlying page.

BUG=681795
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dpapad, 2017-02-21 22:32:21]

The CQ bit was checked by dpapad@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-21 22:35:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dpapad, 2017-02-21 23:19:28]

dpapad@chromium.org changed reviewers:
+ tommycli@chromium.org

[Dan Beam, 2017-02-21 23:25:43]

dbeam@chromium.org changed reviewers:
+ dbeam@chromium.org

[Dan Beam, 2017-02-21 23:25:43]

why not do this in settings-specific cases?  this seems to be just as likely to
NOT do what we want in other situations

for reference, we've done this in the past with cr-dialog

https://codereview.chromium.org/2249933002/
https://codereview.chromium.org/2445713004/

[dpapad, 2017-02-21 23:29:13]

On 2017/02/21 at 23:25:43, dbeam wrote:
> why not do this in settings-specific cases?  this seems to be just as likely
to NOT do what we want in other situations
> 
> for reference, we've done this in the past with cr-dialog
> 
> https://codereview.chromium.org/2249933002/
> https://codereview.chromium.org/2445713004/

I can't find any cases where the user navigates back and we don't want to close
the action menu dialog. Do you have any?
In the cr-dialog case we provide a reasonable default behavior (close on
popstate) and provide a way to override for the few cases that don't want the
default behavior, see [1]. So the action-menu and cr-dialog cases are pretty
much the same, except that we have no reason to provide the |ignorePopState|
option yet.

[1]
https://cs.chromium.org/chromium/src/ui/webui/resources/cr_elements/cr_dialog....

[commit-bot: I haz the power, 2017-02-22 00:40:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-22 00:40:06]

Dry run: Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  closure_compilation on master.tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)

[tommycli, 2017-02-22 01:37:43]

lgtm. I am also in favor of adding the blanket close first, and then dealing
with exceptions when they come up. Greedy algorithm toward work and all that.

[Dan Beam, 2017-02-23 00:12:48]

Description was changed from

==========
WebUI: Close cr-action-menu on popstate event.

Without this the modal dialog stays open (even though not visible), blocking any
interaction with the underlying page.

BUG=681795
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
WebUI: Close cr-action-menu on popstate event.

Without this the modal dialog stays open (even though not visible), blocking any
interaction with the underlying page.

BUG=681795
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Dan Beam, 2017-02-23 00:12:48]

dbeam@chromium.org changed reviewers:
- dbeam@chromium.org

[dpapad, 2017-02-23 00:19:04]

The CQ bit was checked by dpapad@chromium.org

[commit-bot: I haz the power, 2017-02-23 00:19:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-23 03:00:41]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1487809144251940,
"parent_rev": "85a8ce8dd67e4ed84fa7846b3f47f2b8b45b906e", "commit_rev":
"f76cfdd6f9737c1d982d3ab065bac4e58a1d8ff0"}

[commit-bot: I haz the power, 2017-02-23 03:01:24]

Description was changed from

==========
WebUI: Close cr-action-menu on popstate event.

Without this the modal dialog stays open (even though not visible), blocking any
interaction with the underlying page.

BUG=681795
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
WebUI: Close cr-action-menu on popstate event.

Without this the modal dialog stays open (even though not visible), blocking any
interaction with the underlying page.

BUG=681795
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2708863004
Cr-Commit-Position: refs/heads/master@{#452363}
Committed:
https://chromium.googlesource.com/chromium/src/+/f76cfdd6f9737c1d982d3ab065ba...
==========

[commit-bot: I haz the power, 2017-02-23 03:01:25]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/f76cfdd6f9737c1d982d3ab065ba...