Network traffic annotation added to feedback_uploader_chrome.

components/feedback/feedback_uploader_chrome.cc

Index: components/feedback/feedback_uploader_chrome.cc
diff --git a/components/feedback/feedback_uploader_chrome.cc b/components/feedback/feedback_uploader_chrome.cc
index 0b18305d920b12584508bebbf8cb9d4b63cfb666..08f19e0e2224ca50dbfb34d6f49c39ddefee3b4b 100644
--- a/components/feedback/feedback_uploader_chrome.cc
+++ b/components/feedback/feedback_uploader_chrome.cc
@@ -20,6 +20,7 @@
 #include "content/public/browser/browser_thread.h"
 #include "content/public/browser/storage_partition.h"
 #include "net/base/load_flags.h"
+#include "net/traffic_annotation/network_traffic_annotation.h"
 #include "net/url_request/url_fetcher.h"
 #include "url/gurl.h"
 
@@ -47,6 +48,27 @@ FeedbackUploaderChrome::FeedbackUploaderChrome(
 void FeedbackUploaderChrome::DispatchReport(const std::string& data) {
   GURL post_url(url_);
 
+  net::NetworkTrafficAnnotationTag traffic_annotation =
+      net::DefineNetworkTrafficAnnotation("...", R"(
+        semantics {
+          sender: "..."
+          description: "..."
+          trigger: "..."
+          data: "..."
+          destination: WEBSITE/GOOGLE_OWNED_SERVICE/OTHER

[afakhry, 2017/02/25 02:37:37]

Why are these placeholders not set? I don't know how the
NetworkTrafficAnnotationTag should be used, but looking at this example:
https://cs.chromium.org/chromium/src/chrome/browser/apps/drive/drive_app_conv...

The various fields are filled. Can you please explain why we just use "...",
WEBSITE/GOOGLE_OWNED_SERVICE/OTHER, false/true and MANDATORY/RECOMMENDED/UNSET
here without specifying anything in particular?

[Ramin Halavati, 2017/02/27 08:56:30]

I am sorry I wasn't clear in my initial message. I was asking you tho suggest
appropriate text for all place holders.

[afakhry, 2017/03/10 19:17:27]

You can use something like this:

net::NetworkTrafficAnnotationTag traffic_annotation =
    net::DefineNetworkTrafficAnnotation("chrome_feedback_report_app", R"(
      semantics {
        sender: "Chrome Feedbak Report App"
        description: "This uploads the feedback report to Google feedback "
                     "server"
        trigger: "When the feedback report is being uploaded"
        data: "Contents of the report, user entered message, and useful "
              "debugging logs"
        destination: GOOGLE_OWNED_SERVICE
      }
      policy {
      })");

We don't really have any special policies.

+        }
+        policy {
+          cookies_allowed: false/true
+          cookies_store: "..."
+          setting: "..."
+          policy {
+            [POLICY_NAME] {
+              policy_options {mode: MANDATORY/RECOMMENDED/UNSET}
+              value: ...
+            }
+          }
+          policy_exception_justification: "..."
+        })");
   // Note: FeedbackUploaderDelegate deletes itself and the fetcher.
   net::URLFetcher* fetcher =
       net::URLFetcher::Create(
@@ -54,7 +76,8 @@ void FeedbackUploaderChrome::DispatchReport(const std::string& data) {
           new FeedbackUploaderDelegate(
               data, base::Bind(&FeedbackUploaderChrome::UpdateUploadTimer,
                                AsWeakPtr()),
-              base::Bind(&FeedbackUploaderChrome::RetryReport, AsWeakPtr())))
+              base::Bind(&FeedbackUploaderChrome::RetryReport, AsWeakPtr())),
+          traffic_annotation)
           .release();
   data_use_measurement::DataUseUserData::AttachToFetcher(
       fetcher, data_use_measurement::DataUseUserData::FEEDBACK_UPLOADER);