Network traffic annotation added to feedback_uploader_chrome.

components/feedback/feedback_uploader_chrome.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/feedback/feedback_uploader_chrome.h"
 
 #include <string>
 
 #include "base/callback.h"
 #include "base/command_line.h"
 #include "base/files/file_path.h"
 #include "base/task_runner_util.h"
 #include "base/threading/sequenced_worker_pool.h"
 #include "components/data_use_measurement/core/data_use_user_data.h"
 #include "components/feedback/feedback_report.h"
 #include "components/feedback/feedback_switches.h"
 #include "components/feedback/feedback_uploader_delegate.h"
 #include "components/variations/net/variations_http_headers.h"
 #include "content/public/browser/browser_context.h"
 #include "content/public/browser/browser_thread.h"
 #include "content/public/browser/storage_partition.h"
 #include "net/base/load_flags.h"
+#include "net/traffic_annotation/network_traffic_annotation.h"
 #include "net/url_request/url_fetcher.h"
 #include "url/gurl.h"
 
 using content::BrowserThread;
 
 namespace feedback {
 namespace {
 
 const char kProtoBufMimeType[] = "application/x-protobuf";
 
 }  // namespace
 
 FeedbackUploaderChrome::FeedbackUploaderChrome(
     content::BrowserContext* context)
     : FeedbackUploader(context ? context->GetPath() : base::FilePath(),
                        BrowserThread::GetBlockingPool()),
       context_(context) {
   CHECK(context_);
   const base::CommandLine& command_line =
       *base::CommandLine::ForCurrentProcess();
   if (command_line.HasSwitch(switches::kFeedbackServer))
     url_ = command_line.GetSwitchValueASCII(switches::kFeedbackServer);
 }
 
 void FeedbackUploaderChrome::DispatchReport(const std::string& data) {
   GURL post_url(url_);
 
+  net::NetworkTrafficAnnotationTag traffic_annotation =
+      net::DefineNetworkTrafficAnnotation("...", R"(
+        semantics {
+          sender: "..."
+          description: "..."
+          trigger: "..."
+          data: "..."
+          destination: WEBSITE/GOOGLE_OWNED_SERVICE/OTHER

[afakhry, 2017/02/25 02:37:37]

Why are these placeholders not set? I don't know how the
NetworkTrafficAnnotationTag should be used, but looking at this example:
https://cs.chromium.org/chromium/src/chrome/browser/apps/drive/drive_app_conv...

The various fields are filled. Can you please explain why we just use "...",
WEBSITE/GOOGLE_OWNED_SERVICE/OTHER, false/true and MANDATORY/RECOMMENDED/UNSET
here without specifying anything in particular?

[Ramin Halavati, 2017/02/27 08:56:30]

I am sorry I wasn't clear in my initial message. I was asking you tho suggest
appropriate text for all place holders.

[afakhry, 2017/03/10 19:17:27]

You can use something like this:

net::NetworkTrafficAnnotationTag traffic_annotation =
    net::DefineNetworkTrafficAnnotation("chrome_feedback_report_app", R"(
      semantics {
        sender: "Chrome Feedbak Report App"
        description: "This uploads the feedback report to Google feedback "
                     "server"
        trigger: "When the feedback report is being uploaded"
        data: "Contents of the report, user entered message, and useful "
              "debugging logs"
        destination: GOOGLE_OWNED_SERVICE
      }
      policy {
      })");

We don't really have any special policies.

+        }
+        policy {
+          cookies_allowed: false/true
+          cookies_store: "..."
+          setting: "..."
+          policy {
+            [POLICY_NAME] {
+              policy_options {mode: MANDATORY/RECOMMENDED/UNSET}
+              value: ...
+            }
+          }
+          policy_exception_justification: "..."
+        })");
   // Note: FeedbackUploaderDelegate deletes itself and the fetcher.
   net::URLFetcher* fetcher =
       net::URLFetcher::Create(
           post_url, net::URLFetcher::POST,
           new FeedbackUploaderDelegate(
               data, base::Bind(&FeedbackUploaderChrome::UpdateUploadTimer,
                                AsWeakPtr()),
-              base::Bind(&FeedbackUploaderChrome::RetryReport, AsWeakPtr())))
+              base::Bind(&FeedbackUploaderChrome::RetryReport, AsWeakPtr())),
+          traffic_annotation)
           .release();
   data_use_measurement::DataUseUserData::AttachToFetcher(
       fetcher, data_use_measurement::DataUseUserData::FEEDBACK_UPLOADER);
   // Tell feedback server about the variation state of this install.
   net::HttpRequestHeaders headers;
   // Note: It's OK to pass |is_signed_in| false if it's unknown, as it does
   // not affect transmission of experiments coming from the variations server.
   bool is_signed_in = false;
   variations::AppendVariationHeaders(fetcher->GetOriginalURL(),
                                      context_->IsOffTheRecord(), false,
                                      is_signed_in, &headers);
   fetcher->SetExtraRequestHeaders(headers.ToString());
 
   fetcher->SetUploadData(kProtoBufMimeType, data);
   fetcher->SetRequestContext(
       content::BrowserContext::GetDefaultStoragePartition(context_)->
           GetURLRequestContext());
   fetcher->SetLoadFlags(net::LOAD_DO_NOT_SAVE_COOKIES |
                         net::LOAD_DO_NOT_SEND_COOKIES);
   fetcher->Start();
 }
 
 }  // namespace feedback