Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 2708803002: Update script which gathers test run times for typ switchover. (Closed)

Created:
3 years, 10 months ago by Ken Russell (switch to Gerrit)
Modified:
3 years, 10 months ago
Reviewers:
nednguyen, Zhenyao Mo
CC:
chromium-reviews, jam, darin-cc_chromium.org, piman+watch_chromium.org, Dirk Pranke
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update script which gathers test run times for typ switchover. The script was correctly merging the tries, but needed to specifically extract the per-test run times. BUG=636153 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2708803002 Cr-Commit-Position: refs/heads/master@{#452362} Committed: https://chromium.googlesource.com/chromium/src/+/85a8ce8dd67e4ed84fa7846b3f47f2b8b45b906e

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed review feedback from nednguyen. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -40 lines) Patch
M content/test/gpu/gather_swarming_json_results.py View 1 2 chunks +67 lines, -40 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
Ken Russell (switch to Gerrit)
Ned or Mo: please review at your leisure. This should be landed after the typ ...
3 years, 10 months ago (2017-02-21 02:55:27 UTC) #3
nednguyen
lgtm with nit https://codereview.chromium.org/2708803002/diff/1/content/test/gpu/gather_swarming_json_results.py File content/test/gpu/gather_swarming_json_results.py (right): https://codereview.chromium.org/2708803002/diff/1/content/test/gpu/gather_swarming_json_results.py#newcode150 content/test/gpu/gather_swarming_json_results.py:150: dest[node_name] = node['times'][0] hmhh, should we ...
3 years, 10 months ago (2017-02-21 13:39:39 UTC) #4
Ken Russell (switch to Gerrit)
https://codereview.chromium.org/2708803002/diff/1/content/test/gpu/gather_swarming_json_results.py File content/test/gpu/gather_swarming_json_results.py (right): https://codereview.chromium.org/2708803002/diff/1/content/test/gpu/gather_swarming_json_results.py#newcode150 content/test/gpu/gather_swarming_json_results.py:150: dest[node_name] = node['times'][0] On 2017/02/21 13:39:39, nednguyen wrote: > ...
3 years, 10 months ago (2017-02-22 01:19:13 UTC) #5
Zhenyao Mo
lgtm
3 years, 10 months ago (2017-02-23 01:23:55 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2708803002/20001
3 years, 10 months ago (2017-02-23 01:30:02 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-23 03:00:02 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/85a8ce8dd67e4ed84fa7846b3f47...

Powered by Google App Engine
This is Rietveld 408576698