Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(13)

Issue 27088: Additional fix for Sandboxed WebKit on OS X. (Closed)

Created:
8 years, 9 months ago by jeremy
Modified:
6 years, 5 months ago
CC:
chromium-reviews_googlegroups.com, John Grabowski
Visibility:
Public.

Description

Fix for Sandboxed WebKit on OS X: * Cache Gestalt's value since it opens files. * Do a little cleanup in sys_info while I'm there and add a unit test. * Label some methods as not being threadsafe on OSX/POSIX.

Patch Set 1 #

Total comments: 10

Patch Set 2 : Fixes #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -24 lines) Patch
M base/base.xcodeproj/project.pbxproj View 4 chunks +4 lines, -0 lines 0 comments Download
M base/sys_info.h View 1 2 chunks +11 lines, -0 lines 2 comments Download
A base/sys_info_mac.cc View 1 1 chunk +46 lines, -0 lines 0 comments Download
M base/sys_info_posix.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M base/sys_info_unittest.cc View 1 chunk +16 lines, -0 lines 0 comments Download
M base/sys_info_win.cc View 1 chunk +12 lines, -0 lines 0 comments Download
M webkit/glue/webkit_glue.cc View 2 chunks +4 lines, -14 lines 0 comments Download
Trybot results:

Messages

Total messages: 6 (0 generated)
jeremy
8 years, 9 months ago (2009-02-24 14:16:46 UTC) #1
pink (ping after 24hrs)
LGTM with comments. http://codereview.chromium.org/27088/diff/1/4 File base/sys_info_mac.cc (right): http://codereview.chromium.org/27088/diff/1/4#newcode21 Line 21: // Gestalt can't be called ...
8 years, 9 months ago (2009-02-24 14:21:00 UTC) #2
Mark Mentovai
http://codereview.chromium.org/27088/diff/1/3 File base/sys_info.h (right): http://codereview.chromium.org/27088/diff/1/3#newcode17 Line 17: // WARNING: On POSIX, this method uses static ...
8 years, 9 months ago (2009-02-24 14:31:23 UTC) #3
jeremy
http://codereview.chromium.org/27088/diff/1/3 File base/sys_info.h (right): http://codereview.chromium.org/27088/diff/1/3#newcode17 Line 17: // WARNING: On POSIX, this method uses static ...
8 years, 9 months ago (2009-02-24 15:11:50 UTC) #4
pink (ping after 24hrs)
lgtm
8 years, 9 months ago (2009-02-24 15:17:12 UTC) #5
Mark Mentovai
8 years, 9 months ago (2009-02-24 15:19:45 UTC) #6
Oh, I see.  I thought we were going to throw away the 6 in 10.5.6 because that's
what Firefox does, but now I see that we use it on the Mac because Safari does. 
Whatever.

LGTM, carry on.

http://codereview.chromium.org/27088/diff/1003/1005
File base/sys_info.h (right):

http://codereview.chromium.org/27088/diff/1003/1005#newcode18
Line 18: // until its been initialized by being called once without a race.
it's this time :)

http://codereview.chromium.org/27088/diff/1003/1005#newcode50
Line 50: // until its been initialized by being called once without a race.
ditto

Powered by Google App Engine
This is Rietveld efc10ee0f