Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2916)

Unified Diff: base/sys_info.h

Issue 27088: Additional fix for Sandboxed WebKit on OS X. (Closed)
Patch Set: Fixes Created 11 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/base.xcodeproj/project.pbxproj ('k') | base/sys_info_mac.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/sys_info.h
diff --git a/base/sys_info.h b/base/sys_info.h
index 35d371b3b2cb0a0a80bdc56739b48c4e5886ee83..0b4e49b1942d5cd2417911f4cc0fcd7b568cec19 100644
--- a/base/sys_info.h
+++ b/base/sys_info.h
@@ -14,6 +14,8 @@ namespace base {
class SysInfo {
public:
// Return the number of logical processors/cores on the current machine.
+ // WARNING: On POSIX, this method uses static variables and is not threadsafe
+ // until its been initialized by being called once without a race.
Mark Mentovai 2009/02/24 15:19:46 it's this time :)
static int NumberOfProcessors();
// Return the number of bytes of physical memory on the current machine.
@@ -43,6 +45,15 @@ class SysInfo {
// Returns the version of the host operating system.
static std::string OperatingSystemVersion();
+ // Retrieves detailed numeric values for the OS version.
+ // WARNING: On OS X, this method uses static variables and is not threadsafe
+ // until its been initialized by being called once without a race.
Mark Mentovai 2009/02/24 15:19:46 ditto
+ // TODO(port): Implement a Linux version of this method and enable the
+ // corresponding unit test.
+ static void OperatingSystemVersionNumbers(int32 *major_version,
+ int32 *minor_version,
+ int32 *bugfix_version);
+
// Returns the CPU architecture of the system. Exact return value may differ
// across platforms.
static std::string CPUArchitecture();
« no previous file with comments | « base/base.xcodeproj/project.pbxproj ('k') | base/sys_info_mac.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698