[wasm] Remove remaining occurences of the context in wasm code

[wasm] Remove remaining occurences of the context in wasm code

The only remaining allowed occurence of a context is in WASM_TO_JS
code, which is regenerated for each instance.
This CL removes all the rest, to avoid subtle bugs where we might
forget to patch it. By renaming the BuildCallToRuntime method, we make
sure that noone accidentially calls the version which embeds a context.
For consistency, I even remove it from the WasmRunInterpreter stub,
which is never reused for new instantiations.

R=titzer@chromium.org

Review-Url: https://codereview.chromium.org/2708743003
Cr-Commit-Position: refs/heads/master@{#43409}
Committed: https://chromium.googlesource.com/v8/v8/+/e0e8b2a2f2370363aa6a502e28acca193bd037cf

[Clemens Hammacher, 2017-02-20 19:14:22]

The CQ bit was checked by clemensh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-20 19:14:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-20 19:19:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-20 19:19:03]

Dry run: Try jobs failed on following builders:
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)

[Clemens Hammacher, 2017-02-20 19:24:24]

The CQ bit was checked by clemensh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-20 19:24:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-20 19:47:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-20 19:47:58]

Dry run: This issue passed the CQ dry run.

[Clemens Hammacher, 2017-02-24 09:03:15]

Ping

[titzer, 2017-02-24 09:06:06]

lgtm with comment nit

https://codereview.chromium.org/2708743003/diff/20001/src/compiler/wasm-compi...
File src/compiler/wasm-compiler.cc (right):

https://codereview.chromium.org/2708743003/diff/20001/src/compiler/wasm-compi...
src/compiler/wasm-compiler.cc:70: // Do only call this function for code which
is not reused across
s/Do only/Only/

[Clemens Hammacher, 2017-02-24 09:28:23]

The CQ bit was checked by clemensh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-24 09:28:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-24 09:53:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-24 09:53:25]

Dry run: This issue passed the CQ dry run.

[Clemens Hammacher, 2017-02-24 09:57:03]

The CQ bit was checked by clemensh@chromium.org

[Clemens Hammacher, 2017-02-24 09:57:04]

The patchset sent to the CQ was uploaded after l-g-t-m from titzer@chromium.org
Link to the patchset: https://codereview.chromium.org/2708743003/#ps40001
(title: "Fix comment")

[commit-bot: I haz the power, 2017-02-24 09:57:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-24 09:59:23]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1487930223806860,
"parent_rev": "5b8f1f84a4316da06103fab2d970f05d14e45993", "commit_rev":
"e0e8b2a2f2370363aa6a502e28acca193bd037cf"}

[commit-bot: I haz the power, 2017-02-24 09:59:28]

Description was changed from

==========
[wasm] Remove remaining occurences of the context in wasm code

The only remaining allowed occurence of a context is in WASM_TO_JS
code, which is regenerated for each instance.
This CL removes all the rest, to avoid subtle bugs where we might
forget to patch it. By renaming the BuildCallToRuntime method, we make
sure that noone accidentially calls the version which embeds a context.
For consistency, I even remove it from the WasmRunInterpreter stub,
which is never reused for new instantiations.

R=titzer@chromium.org
==========

to

==========
[wasm] Remove remaining occurences of the context in wasm code

The only remaining allowed occurence of a context is in WASM_TO_JS
code, which is regenerated for each instance.
This CL removes all the rest, to avoid subtle bugs where we might
forget to patch it. By renaming the BuildCallToRuntime method, we make
sure that noone accidentially calls the version which embeds a context.
For consistency, I even remove it from the WasmRunInterpreter stub,
which is never reused for new instantiations.

R=titzer@chromium.org

Review-Url: https://codereview.chromium.org/2708743003
Cr-Commit-Position: refs/heads/master@{#43409}
Committed:
https://chromium.googlesource.com/v8/v8/+/e0e8b2a2f2370363aa6a502e28acca193bd...
==========

[commit-bot: I haz the power, 2017-02-24 09:59:29]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/v8/v8/+/e0e8b2a2f2370363aa6a502e28acca193bd...

[Clemens Hammacher, 2017-02-24 10:00:41]

https://codereview.chromium.org/2708743003/diff/20001/src/compiler/wasm-compi...
File src/compiler/wasm-compiler.cc (right):

https://codereview.chromium.org/2708743003/diff/20001/src/compiler/wasm-compi...
src/compiler/wasm-compiler.cc:70: // Do only call this function for code which
is not reused across
On 2017/02/24 at 09:06:06, titzer wrote:
> s/Do only/Only/

Done.