third_party/WebKit/Source/core/page/DragController.cpp - Issue 2708703003: Expand FrameSeleciton::isRange() to increase chances of hoisting update layout

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/page/DragController.cpp

Issue 2708703003: Expand FrameSeleciton::isRange() to increase chances of hoisting update layout (Closed)

Patch Set: 2017-02-21T23:48:22 rebase Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/page/DragController.cpp

diff --git a/third_party/WebKit/Source/core/page/DragController.cpp b/third_party/WebKit/Source/core/page/DragController.cpp

index 4622e1d96acb0398dfaba2deea2d3311fe8b62c4..9483dab469c5f2a40082349255947b8dff86d795 100644

--- a/third_party/WebKit/Source/core/page/DragController.cpp

+++ b/third_party/WebKit/Source/core/page/DragController.cpp

@@ -199,7 +199,8 @@ static DocumentFragment* documentFragmentFromDragData(

bool DragController::dragIsMove(FrameSelection& selection, DragData* dragData) {

return m_documentUnderMouse == m_dragInitiator &&

- selection.isContentEditable() && selection.isRange() &&

+ selection.isContentEditable() &&

+ selection.computeVisibleSelectionInDOMTreeDeprecated().isRange() &&

!isCopyKeyDown(dragData);

}