Use native coordinates to warp the cursor to another display.

Use native coordinates to warp the cursor to another display.

This is roughly how this works.
- Takes the bounds of the edge indicator in screen coords
  and convert to native coords
- If the location of mouse in native coords moves into this
  bounds, we need to warp the mouse.
- Convert the current mouse location in screen coords to the
  destination window's host coords. Adjust so that the location is inside the host window's bounds.

No flag. I'll simply flip the flag if I need to disable this on branch.

BUG=321699, 306632
TEST=TBD

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269758

[oshima, 2014-05-09 20:08:58]

I'm still working on test, but the rest is ready. PTAL.

[Jun Mukai, 2014-05-09 21:01:56]

lgtm if it passes the tests. a few nits

https://codereview.chromium.org/270863005/diff/160001/ash/display/mouse_curso...
File ash/display/mouse_cursor_event_filter.cc (right):

https://codereview.chromium.org/270863005/diff/160001/ash/display/mouse_curso...
ash/display/mouse_cursor_event_filter.cc:45: bool
enable_mouse_warp_in_native_coords = true;
nit: global variable starts with 'g_'?

https://codereview.chromium.org/270863005/diff/160001/ash/display/mouse_curso...
ash/display/mouse_cursor_event_filter.cc:194: DisplayLayout::Position position =
Shell::GetInstance()
nit: I personally don't like this style of linebreaks. Why not:
position =
    Shell::GetInstance()->display_manager()->GetCurrentDisplayLayout().position;

If it doesn't fit in 80 columns, I prefer to linebreak after the operator.

[oshima, 2014-05-09 23:50:06]

I updated the test. I also had to update the code to make it test friendly. Can
you take another look?

https://codereview.chromium.org/270863005/diff/160001/ash/display/mouse_curso...
File ash/display/mouse_cursor_event_filter.cc (right):

https://codereview.chromium.org/270863005/diff/160001/ash/display/mouse_curso...
ash/display/mouse_cursor_event_filter.cc:45: bool
enable_mouse_warp_in_native_coords = true;
On 2014/05/09 21:01:57, Jun Mukai wrote:
> nit: global variable starts with 'g_'?

This is file scoped variable, not global scoped variable.

https://codereview.chromium.org/270863005/diff/160001/ash/display/mouse_curso...
ash/display/mouse_cursor_event_filter.cc:194: DisplayLayout::Position position =
Shell::GetInstance()
On 2014/05/09 21:01:57, Jun Mukai wrote:
> nit: I personally don't like this style of linebreaks. Why not:
> position =
>    
Shell::GetInstance()->display_manager()->GetCurrentDisplayLayout().position;
> 
> If it doesn't fit in 80 columns, I prefer to linebreak after the operator.

This is what "git cl format" does, and I'm inclined to just accept it rather
than
changing what's been formatted. let me know if you feel strongly about it and
I'm fine to change it.

https://codereview.chromium.org/270863005/diff/180001/ash/display/mouse_curso...
File ash/display/mouse_cursor_event_filter.cc (right):

https://codereview.chromium.org/270863005/diff/180001/ash/display/mouse_curso...
ash/display/mouse_cursor_event_filter.cc:293: was_mouse_warped_ = true;
this was missing.

[Jun Mukai, 2014-05-10 01:26:20]

https://codereview.chromium.org/270863005/diff/200001/ash/display/mouse_curso...
File ash/display/mouse_cursor_event_filter.cc (right):

https://codereview.chromium.org/270863005/diff/200001/ash/display/mouse_curso...
ash/display/mouse_cursor_event_filter.cc:293: was_mouse_warped_ = true;
Well, I got confused. We don't need this flag anymore in this code path right?

https://codereview.chromium.org/270863005/diff/200001/ash/display/mouse_curso...
File ash/display/mouse_cursor_event_filter_unittest.cc (right):

https://codereview.chromium.org/270863005/diff/200001/ash/display/mouse_curso...
ash/display/mouse_cursor_event_filter_unittest.cc:130: // because 1px left of
(0, 499) is inside the primary root window.
Please update the comment as well.

[oshima, 2014-05-10 14:58:06]

https://codereview.chromium.org/270863005/diff/200001/ash/display/mouse_curso...
File ash/display/mouse_cursor_event_filter.cc (right):

https://codereview.chromium.org/270863005/diff/200001/ash/display/mouse_curso...
ash/display/mouse_cursor_event_filter.cc:293: was_mouse_warped_ = true;
On 2014/05/10 01:26:20, Jun Mukai wrote:
> Well, I got confused. We don't need this flag anymore in this code path right?

Yes, you're absolutely right. Removed and updated the test.

https://codereview.chromium.org/270863005/diff/200001/ash/display/mouse_curso...
File ash/display/mouse_cursor_event_filter_unittest.cc (right):

https://codereview.chromium.org/270863005/diff/200001/ash/display/mouse_curso...
ash/display/mouse_cursor_event_filter_unittest.cc:130: // because 1px left of
(0, 499) is inside the primary root window.
On 2014/05/10 01:26:20, Jun Mukai wrote:
> Please update the comment as well.

Done.

[oshima, 2014-05-10 14:58:13]

The CQ bit was checked by oshima@chromium.org

[commit-bot: I haz the power, 2014-05-10 14:59:34]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/oshima@chromium.org/270863005/220001

[commit-bot: I haz the power, 2014-05-10 17:03:13]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  win_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_compile_...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)

[commit-bot: I haz the power, 2014-05-10 17:57:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-10 17:57:50]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)

[oshima, 2014-05-11 14:59:02]

The CQ bit was checked by oshima@chromium.org

[commit-bot: I haz the power, 2014-05-11 14:59:11]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/oshima@chromium.org/270863005/250015

[commit-bot: I haz the power, 2014-05-11 18:56:16]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  win_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_compile_...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)

[commit-bot: I haz the power, 2014-05-11 19:19:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-11 19:19:44]

Try jobs failed on following builders:
  win_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_compile_...)

[oshima, 2014-05-11 21:57:57]

The CQ bit was checked by oshima@chromium.org

[commit-bot: I haz the power, 2014-05-11 21:58:02]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/oshima@chromium.org/270863005/270001

[oshima_google, 2014-05-12 02:01:54]

The CQ bit was unchecked by oshima@google.com

[oshima_google, 2014-05-12 02:02:07]

The CQ bit was checked by oshima@google.com

[commit-bot: I haz the power, 2014-05-12 02:02:13]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/oshima@chromium.org/270863005/290001

[commit-bot: I haz the power, 2014-05-12 07:47:30]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)

[commit-bot: I haz the power, 2014-05-12 09:39:51]

Change committed as 269758