Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Issue 2708593002: Revert of [wasm] Identify wasm functions with index into the function tables. (Closed)

Created:
3 years, 10 months ago by Michael Hablich
Modified:
3 years, 10 months ago
Reviewers:
gdeepti, Mircea Trofin
CC:
v8-reviews_googlegroups.com, titzer
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [wasm] Identify wasm functions with index into the function tables. (patchset #7 id:110001 of https://codereview.chromium.org/2690113012/ ) Reason for revert: Introduces a new test failure/flake: https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20debug/builds/13707 Original issue's description: > [wasm] Identify wasm functions with index into the function tables. > > Currently, the default name for wasm functions in generated code is 'wasm', tag wasm functions with the index into the function table to identify functions. Snippets of sample output with --print-code below. > > Before: > --- Code --- > kind = WASM_FUNCTION > name = wasm > compiler = turbofan > > After: > --- Code --- > kind = WASM_FUNCTION > name = wasm#200 > compiler = turbofan > > R=mtrofin@chromium.org > > Review-Url: https://codereview.chromium.org/2690113012 > Cr-Commit-Position: refs/heads/master@{#43296} > Committed: https://chromium.googlesource.com/v8/v8/+/5fc3ac29e4d942ccb4c45f6cdcee75d0b394b296 TBR=mtrofin@chromium.org,gdeepti@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. Review-Url: https://codereview.chromium.org/2708593002 Cr-Commit-Position: refs/heads/master@{#43302} Committed: https://chromium.googlesource.com/v8/v8/+/96afb852bce557f1eb8768e9e9b39a38853ec3cd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -11 lines) Patch
M src/compiler/wasm-compiler.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/compiler/wasm-compiler.cc View 2 chunks +1 line, -8 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Michael Hablich
Created Revert of [wasm] Identify wasm functions with index into the function tables.
3 years, 10 months ago (2017-02-20 07:30:30 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2708593002/1
3 years, 10 months ago (2017-02-20 07:30:39 UTC) #3
commit-bot: I haz the power
3 years, 10 months ago (2017-02-20 07:53:32 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/96afb852bce557f1eb8768e9e9b39a38853...

Powered by Google App Engine
This is Rietveld 408576698