Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issue 2708563002: DevTools: allow embedder handling async remote debugger commands. (Closed)

Created:
3 years, 10 months ago by jzfeng
Modified:
3 years, 10 months ago
Reviewers:
Eric Seckler, pfeldman
CC:
chromium-reviews, jam, darin-cc_chromium.org, pfeldman, devtools-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: allow embedder handling async remote debugger commands. This feature will be used by print to pdf command. BUG=603559 Review-Url: https://codereview.chromium.org/2708563002 Cr-Commit-Position: refs/heads/master@{#451947} Committed: https://chromium.googlesource.com/chromium/src/+/f3b6d48d62cd94949132a97e03155dfd7a9cdf86

Patch Set 1 #

Patch Set 2 : add print to pdf command #

Total comments: 1

Patch Set 3 : extract variable #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -15 lines) Patch
M content/browser/devtools/devtools_session.h View 3 chunks +5 lines, -0 lines 0 comments Download
M content/browser/devtools/devtools_session.cc View 1 2 3 chunks +22 lines, -12 lines 0 comments Download
M content/browser/devtools/protocol/page_handler.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/devtools/protocol/page_handler.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download
M content/browser/devtools/protocol_config.json View 1 1 chunk +2 lines, -2 lines 0 comments Download
M content/public/browser/devtools_manager_delegate.h View 2 chunks +7 lines, -0 lines 0 comments Download
M content/public/browser/devtools_manager_delegate.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/browser_protocol.json View 1 1 chunk +8 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/inspector_protocol_config.json View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 21 (13 generated)
jzfeng
PTAL.
3 years, 10 months ago (2017-02-20 04:58:07 UTC) #2
pfeldman
lgtm https://codereview.chromium.org/2708563002/diff/20001/content/browser/devtools/devtools_session.cc File content/browser/devtools/devtools_session.cc (right): https://codereview.chromium.org/2708563002/diff/20001/content/browser/devtools/devtools_session.cc#newcode68 content/browser/devtools/devtools_session.cc:68: static_cast<base::DictionaryValue*>(value.get()))); nit: extract variable.
3 years, 10 months ago (2017-02-21 19:10:24 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2708563002/40001
3 years, 10 months ago (2017-02-22 01:56:48 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromeos_amd64-generic_chromium_compile_only_ng on ...
3 years, 10 months ago (2017-02-22 03:59:28 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2708563002/40001
3 years, 10 months ago (2017-02-22 04:14:53 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/315558)
3 years, 10 months ago (2017-02-22 07:24:24 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2708563002/40001
3 years, 10 months ago (2017-02-22 07:26:56 UTC) #18
commit-bot: I haz the power
3 years, 10 months ago (2017-02-22 09:11:30 UTC) #21
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/f3b6d48d62cd94949132a97e0315...

Powered by Google App Engine
This is Rietveld 408576698