Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 2708543003: Clean up the getLayoutSVGResource*ById helpers (Closed)

Created:
3 years, 10 months ago by fs
Modified:
3 years, 10 months ago
Reviewers:
Stephen Chennney, pdr.
CC:
fs, blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, krit, eae+blinkwatch, fmalita+watch_chromium.org, gyuyoung2, jchaffraix+rendering, kouhei+svg_chromium.org, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clean up the getLayoutSVGResource*ById helpers Drop getLayoutSVGResourceContainerById helper, since we can just use SVGTreeScopeResources::resourceById directly. For getLayoutSVGResourceById, rather than calling through TreeScope::ensureSVGTreeScopedResources, just pass the SVGTreeScopeResources and do the lookup from there. Said object is already available in the relevant places (only the layout tree dumping needs to be updated wrt that.) BUG=454767 Review-Url: https://codereview.chromium.org/2708543003 Cr-Commit-Position: refs/heads/master@{#451839} Committed: https://chromium.googlesource.com/chromium/src/+/7161f0e4a74110c45b7ca11fd3292a8c3ea7b965

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -49 lines) Patch
M third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceContainer.h View 1 chunk +3 lines, -15 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/SVGLayoutTreeAsText.cpp View 4 chunks +8 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/SVGResources.cpp View 7 chunks +22 lines, -29 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
fs
3 years, 10 months ago (2017-02-20 12:05:24 UTC) #4
Stephen Chennney
lgtm
3 years, 10 months ago (2017-02-21 18:24:01 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2708543003/1
3 years, 10 months ago (2017-02-21 18:27:30 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-21 21:45:02 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/7161f0e4a74110c45b7ca11fd329...

Powered by Google App Engine
This is Rietveld 408576698