Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3112)

Unified Diff: cc/input/scroll_state.h

Issue 2708493002: Refactor scroll chaining to use ScrollNodes without going through LayerImpl (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | cc/input/scroll_state.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/input/scroll_state.h
diff --git a/cc/input/scroll_state.h b/cc/input/scroll_state.h
index 86bc6581de31e99fc3d73299ed57783a4e62dd55..6df0b74af53b9fa3ee8807757291f0e3be575e9c 100644
--- a/cc/input/scroll_state.h
+++ b/cc/input/scroll_state.h
@@ -61,11 +61,10 @@ class CC_EXPORT ScrollState {
data_.is_direct_manipulation = is_direct_manipulation;
}
- void set_scroll_chain_and_layer_tree(
- const std::list<const ScrollNode*>& scroll_chain,
- LayerTreeImpl* layer_tree_impl) {
+ void set_scroll_chain_and_layer_tree(std::list<ScrollNode*>* scroll_chain,
bokan 2017/02/21 19:33:39 Nit, why pass by pointer rather than const-ref?
pdr. 2017/02/22 21:35:59 Good catch, this was just a mistake. I started rem
+ LayerTreeImpl* layer_tree_impl) {
layer_tree_impl_ = layer_tree_impl;
- scroll_chain_ = scroll_chain;
+ scroll_chain_ = *scroll_chain;
}
void set_current_native_scrolling_node(ScrollNode* scroll_node) {
@@ -99,7 +98,7 @@ class CC_EXPORT ScrollState {
private:
ScrollStateData data_;
LayerTreeImpl* layer_tree_impl_;
- std::list<const ScrollNode*> scroll_chain_;
+ std::list<ScrollNode*> scroll_chain_;
};
} // namespace cc
« no previous file with comments | « no previous file | cc/input/scroll_state.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698