Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2708423002:
DelegatedFrameHost should not send immediate ack when compositor is null (Closed)
|
Created:
3 years, 10 months ago by Saman Sami Modified:
3 years, 10 months ago CC:
chromium-reviews, jam, jbauman+watch_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org, kalyank, danakj+watch_chromium.org, xjz+watch_chromium.org, miu+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionCurrently, DelegatedFrameHost sends an immediate ack when compositor is null, but we believe
this is not necessary.
BUG=692880
TBR=jam@chromium.org
Review-Url: https://codereview.chromium.org/2708423002
Cr-Commit-Position: refs/heads/master@{#452501}
Committed: https://chromium.googlesource.com/chromium/src/+/955e4e20be0b90a0b5dde5877ec19167baffa0b4
Patch Set 1 #Patch Set 2 : Remove unit test #
Messages
Total messages: 33 (25 generated)
The CQ bit was checked by samans@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
The CQ bit was checked by samans@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Test ========== to ========== ==========
Description was changed from ========== ========== to ========== Currently, one reason for sending immediate acks in DelegatedFrameHost is having a null compositor, but we believe it's not necessary to send an immediate ack in such a case. ==========
Description was changed from ========== Currently, one reason for sending immediate acks in DelegatedFrameHost is having a null compositor, but we believe it's not necessary to send an immediate ack in such a case. ========== to ========== Currently, DelegatedFrameHost sends an immediate ack when compositor is null, but we believe this is not necessary. ==========
The CQ bit was unchecked by samans@chromium.org
The CQ bit was checked by samans@chromium.org
samans@chromium.org changed reviewers: + fsamuel@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. Committers are members of the group "project-chromium-committers". Note that this has nothing to do with OWNERS files.
Description was changed from ========== Currently, DelegatedFrameHost sends an immediate ack when compositor is null, but we believe this is not necessary. ========== to ========== Currently, DelegatedFrameHost sends an immediate ack when compositor is null, but we believe this is not necessary. BUG=692880 ==========
The CQ bit was checked by samans@chromium.org to run a CQ dry run
The CQ bit was unchecked by samans@chromium.org
The CQ bit was checked by samans@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
LGTM once all the bots are green. Please get jbauman@ to review too, and jam@ to rubberstamp.
samans@chromium.org changed reviewers: + jam@chromium.org, jbauman@chromium.org
jbauman@: Please review all files. jam@: Please review all files.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
I think you can TBR jam@ for what it's worth, jbauman@ and I have reviewed for correctness.
Description was changed from ========== Currently, DelegatedFrameHost sends an immediate ack when compositor is null, but we believe this is not necessary. BUG=692880 ========== to ========== Currently, DelegatedFrameHost sends an immediate ack when compositor is null, but we believe this is not necessary. BUG=692880 TBR=jam@chromium.org ==========
The CQ bit was checked by samans@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1487864892296760,
"parent_rev": "2dda8a2943758301a604edca65fddab396cf77d7", "commit_rev":
"955e4e20be0b90a0b5dde5877ec19167baffa0b4"}
Message was sent while issue was closed.
Description was changed from ========== Currently, DelegatedFrameHost sends an immediate ack when compositor is null, but we believe this is not necessary. BUG=692880 TBR=jam@chromium.org ========== to ========== Currently, DelegatedFrameHost sends an immediate ack when compositor is null, but we believe this is not necessary. BUG=692880 TBR=jam@chromium.org Review-Url: https://codereview.chromium.org/2708423002 Cr-Commit-Position: refs/heads/master@{#452501} Committed: https://chromium.googlesource.com/chromium/src/+/955e4e20be0b90a0b5dde5877ec1... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/955e4e20be0b90a0b5dde5877ec1... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
