Be strict about input in the GCMMessageCryptographer

Be strict about input in the GCMMessageCryptographer

The cryptographer used to be lenient about input, which was reflected by
a series of unit tests that passed in values that wouldn't match real
world input.

The GCMEncryptionProvider's job is to validate the received input,
whereas the GCMMessageCryptographer should assume it's correct.

This CL adds a bunch of DCHECKs, and updates the tests to make sure
valid values are passed in where expected.

BUG=679789
Review-Url: https://codereview.chromium.org/2708383002
Cr-Commit-Position: refs/heads/master@{#470284}
Committed: https://chromium.googlesource.com/chromium/src/+/33f2124d4b3245ca20d3ceb683b15858ffa524c4

[Peter Beverloo, 2017-02-22 17:34:37]

Patchset #1 (id:1) has been deleted

[Peter Beverloo, 2017-02-22 17:34:44]

The CQ bit was checked by peter@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-22 17:35:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Peter Beverloo, 2017-02-22 17:37:35]

peter@chromium.org changed reviewers:
+ davidben@chromium.org

[Peter Beverloo, 2017-02-22 17:37:36]

Hi David,

This is the second CL. Functional change is that we move from soft error
checking to DCHECKs. (The GCMEncryptionProvider validates input.) Two other
notable changes:

- The {recipient,sender}_public_key_ and ecdh_shared_secret_ in the tests are
now actually associated.
- The tests now use more raw bytes and less base64url. Also have a per-test
vector auth secret.

The rest is mechanical.

[commit-bot: I haz the power, 2017-02-22 19:24:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-22 19:24:33]

Dry run: This issue passed the CQ dry run.

[Peter Beverloo, 2017-02-23 16:45:48]

The CQ bit was checked by peter@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-23 16:46:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-23 17:35:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-23 17:35:53]

Dry run: This issue passed the CQ dry run.

[eroman, 2017-05-05 20:55:34]

eroman@chromium.org changed reviewers:
+ eroman@chromium.org

[eroman, 2017-05-05 20:55:34]

lgtm

[Peter Beverloo, 2017-05-08 16:13:45]

The CQ bit was checked by peter@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-08 16:14:27]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-08 16:44:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-08 16:44:47]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[Peter Beverloo, 2017-05-09 11:19:12]

The CQ bit was checked by peter@chromium.org

[Peter Beverloo, 2017-05-09 11:19:13]

The patchset sent to the CQ was uploaded after l-g-t-m from eroman@chromium.org
Link to the patchset: https://codereview.chromium.org/2708383002/#ps60001
(title: "rebase")

[commit-bot: I haz the power, 2017-05-09 11:19:43]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-09 11:35:39]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1494328752494960,
"parent_rev": "01197c1680045ef0b32095c393e4ad9ef314cbbc", "commit_rev":
"33f2124d4b3245ca20d3ceb683b15858ffa524c4"}

[commit-bot: I haz the power, 2017-05-09 11:35:51]

Description was changed from

==========
Be strict about input in the GCMMessageCryptographer

The cryptographer used to be lenient about input, which was reflected by
a series of unit tests that passed in values that wouldn't match real
world input.

The GCMEncryptionProvider's job is to validate the received input,
whereas the GCMMessageCryptographer should assume it's correct.

This CL adds a bunch of DCHECKs, and updates the tests to make sure
valid values are passed in where expected.

BUG=679789
==========

to

==========
Be strict about input in the GCMMessageCryptographer

The cryptographer used to be lenient about input, which was reflected by
a series of unit tests that passed in values that wouldn't match real
world input.

The GCMEncryptionProvider's job is to validate the received input,
whereas the GCMMessageCryptographer should assume it's correct.

This CL adds a bunch of DCHECKs, and updates the tests to make sure
valid values are passed in where expected.

BUG=679789

Review-Url: https://codereview.chromium.org/2708383002
Cr-Commit-Position: refs/heads/master@{#470284}
Committed:
https://chromium.googlesource.com/chromium/src/+/33f2124d4b3245ca20d3ceb683b1...
==========

[commit-bot: I haz the power, 2017-05-09 11:35:52]

Committed patchset #3 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/33f2124d4b3245ca20d3ceb683b1...