Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issue 2708373004: Merged: [wasm] Remove support for experimental version 0xD. (Closed)

Created:
3 years, 10 months ago by bradnelson
Modified:
3 years, 9 months ago
CC:
v8-reviews_googlegroups.com, v8-merges_googlegroups.com, ulan
Target Ref:
refs/pending/branch-heads/5.7
Project:
v8
Visibility:
Public.

Description

Merged: [wasm] Remove support for experimental version 0xD. Revision: 6a09a41622d65d07fcb4436ddfaaaa6a9cad2467 BUG=chromium:575167, chromium:694657 LOG=N NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true R=mtrofin@chromium.org Review-Url: https://codereview.chromium.org/2708373004 . Cr-Commit-Position: refs/branch-heads/5.7@{#128} Cr-Branched-From: 975e9a320b6eaf9f12280c35df98e013beb8f041-refs/heads/5.7.492@{#1} Cr-Branched-From: 8d76f0e3465a84bbf0bceab114900fbe75844e1f-refs/heads/master@{#42426} Committed: https://chromium.googlesource.com/v8/v8/+/e22438bbc6935b0d11cccf6193344c1000b4d6a2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -4 lines) Patch
M src/wasm/module-decoder.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/wasm/wasm-module.h View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (3 generated)
bradnelson
3 years, 10 months ago (2017-02-22 21:23:02 UTC) #1
bradnelson
NOTE: This script will no longer automatically update include/v8-version.h and create a tag. This is ...
3 years, 10 months ago (2017-02-22 21:23:03 UTC) #2
Mircea Trofin
On 2017/02/22 21:23:03, bradnelson wrote: > NOTE: This script will no longer automatically update include/v8-version.h ...
3 years, 10 months ago (2017-02-22 21:24:03 UTC) #3
bradnelson
Committed patchset #1 (id:1) manually as e22438bbc6935b0d11cccf6193344c1000b4d6a2.
3 years, 10 months ago (2017-02-22 21:24:20 UTC) #5
Michael Achenbach
branch 5.7 doesn't compile after this merge, please fix or revert: https://build.chromium.org/p/client.v8.branches/builders/V8%20ppc%20-%20sim%20-%20beta%20branch/builds/346
3 years, 9 months ago (2017-02-28 18:25:05 UTC) #7
Michael Achenbach
On 2017/02/28 18:25:05, Michael Achenbach wrote: > branch 5.7 doesn't compile after this merge, please ...
3 years, 9 months ago (2017-02-28 18:26:47 UTC) #8
bradn
Fix coming shortly.
3 years, 9 months ago (2017-02-28 18:28:30 UTC) #10
bradn
Yes, actually we're unsure on this end if we can merge things as hablich is ...
3 years, 9 months ago (2017-02-28 18:35:23 UTC) #11
Michael Hablich
I am not away :-). If the branch builders are broken, you don't need to ...
3 years, 9 months ago (2017-02-28 20:02:07 UTC) #12
bradn
3 years, 9 months ago (2017-02-28 20:05:42 UTC) #13
Message was sent while issue was closed.
I think we had not realized the branch builder went red (and then when we got
this CL, misunderstood and thought this was a fix for something we didn't have a
builder for).

Powered by Google App Engine
This is Rietveld 408576698