Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2708373003:
Regenerate perf JSON now that battor.power_cases_no_chrome_trace is gone (Closed)
|
Created:
3 years, 10 months ago by charliea (OOO until 10-5) Modified:
3 years, 10 months ago CC:
chromium-reviews Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRegenerate perf JSON now that battor.power_cases_no_chrome_trace is gone
I didn't realize I had to do this earlier, and now it's causing problems
on bots.
BUG=695156
Review-Url: https://codereview.chromium.org/2708373003
Cr-Commit-Position: refs/heads/master@{#452539}
Committed: https://chromium.googlesource.com/chromium/src/+/ee09c859d3f509fc33d7c9e3b3ffe0959644f9e2
Patch Set 1 #
Messages
Total messages: 25 (11 generated)
charliea@chromium.org changed reviewers: + nednguyen@google.com
On 2017/02/22 20:12:10, charliea wrote: lgtm
The CQ bit was checked by charliea@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
On 2017/02/22 20:26:40, commit-bot: I haz the power wrote: > Try jobs failed on following builders: > chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, > http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...) err, I don't have owner. Just send this to kbr@ or dpranke@
charliea@chromium.org changed reviewers: + dpranke@google.com
dpranke@, could you put a quick stamp on this?
charliea@chromium.org changed reviewers: + sullivan@chromium.org - dpranke@google.com
Removing dpranke@ (just saw that sullivan@ is also an owner)
lgtm
The CQ bit was checked by charliea@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
On 2017/02/23 15:08:38, commit-bot: I haz the power wrote: > Try jobs failed on following builders: > chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, > http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...) Just TBR Dave for the fyi file change
dpranke@chromium.org changed reviewers: + dpranke@chromium.org
lgtm
The CQ bit was checked by nednguyen@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1487871278746300, "parent_rev":
"e7b6ddf8b2940d17dc8dd0feaffce5b33ecee785", "commit_rev":
"ee09c859d3f509fc33d7c9e3b3ffe0959644f9e2"}
Message was sent while issue was closed.
Description was changed from ========== Regenerate perf JSON now that battor.power_cases_no_chrome_trace is gone I didn't realize I had to do this earlier, and now it's causing problems on bots. BUG=695156 ========== to ========== Regenerate perf JSON now that battor.power_cases_no_chrome_trace is gone I didn't realize I had to do this earlier, and now it's causing problems on bots. BUG=695156 Review-Url: https://codereview.chromium.org/2708373003 Cr-Commit-Position: refs/heads/master@{#452539} Committed: https://chromium.googlesource.com/chromium/src/+/ee09c859d3f509fc33d7c9e3b3ff... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/ee09c859d3f509fc33d7c9e3b3ff... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
