Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(997)

Issue 2708363003: Remove unused tags from blink::SerializationTag. (Closed)

Created:
3 years, 10 months ago by jbroman
Modified:
3 years, 10 months ago
Reviewers:
haraken
CC:
blink-reviews, blink-reviews-bindings_chromium.org, chromium-reviews, jbroman+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unused tags from blink::SerializationTag. These tags are no longer interpreted by Blink, so all enumerators not used in the Blink-side logic have been removed. BUG=690132 Review-Url: https://codereview.chromium.org/2708363003 Cr-Commit-Position: refs/heads/master@{#452283} Committed: https://chromium.googlesource.com/chromium/src/+/d6e33a43cc4b5bd70dd69f9104fbf8d31fc31c70

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -80 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/SerializationTag.h View 4 chunks +2 lines, -79 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/serialization/V8ScriptValueDeserializer.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
jbroman
3 years, 10 months ago (2017-02-22 18:45:18 UTC) #3
haraken
LGTM
3 years, 10 months ago (2017-02-22 23:28:10 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2708363003/1
3 years, 10 months ago (2017-02-22 23:29:39 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-22 23:55:14 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d6e33a43cc4b5bd70dd69f9104fb...

Powered by Google App Engine
This is Rietveld 408576698