Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2708353008: Make it safe to initialize the notificationManager in server (Closed)

Created:
3 years, 9 months ago by Brian Wilkerson
Modified:
3 years, 9 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Make it safe to initialize the notificationManager in server R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/37c585e84235a53039bdb1c0671299628c67baeb

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -17 lines) Patch
M pkg/analysis_server/lib/src/analysis_server.dart View 4 chunks +11 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/plugin/notification_manager.dart View 3 chunks +5 lines, -5 lines 0 comments Download
M pkg/analysis_server/test/src/plugin/notification_manager_test.dart View 10 chunks +10 lines, -10 lines 3 comments Download

Messages

Total messages: 7 (2 generated)
Brian Wilkerson
Notification support isn't initialized yet because we don't need it, but it should now be ...
3 years, 9 months ago (2017-02-23 19:08:41 UTC) #2
scheglov
LGTM https://codereview.chromium.org/2708353008/diff/1/pkg/analysis_server/test/src/plugin/notification_manager_test.dart File pkg/analysis_server/test/src/plugin/notification_manager_test.dart (right): https://codereview.chromium.org/2708353008/diff/1/pkg/analysis_server/test/src/plugin/notification_manager_test.dart#newcode57 pkg/analysis_server/test/src/plugin/notification_manager_test.dart:57: server.AnalysisService.FOLDING: new Set.from([fileA, fileB]) Or [fileA, fileB].toSet()
3 years, 9 months ago (2017-02-23 20:02:43 UTC) #3
Brian Wilkerson
https://codereview.chromium.org/2708353008/diff/1/pkg/analysis_server/test/src/plugin/notification_manager_test.dart File pkg/analysis_server/test/src/plugin/notification_manager_test.dart (right): https://codereview.chromium.org/2708353008/diff/1/pkg/analysis_server/test/src/plugin/notification_manager_test.dart#newcode57 pkg/analysis_server/test/src/plugin/notification_manager_test.dart:57: server.AnalysisService.FOLDING: new Set.from([fileA, fileB]) Do you have a significant ...
3 years, 9 months ago (2017-02-23 20:07:48 UTC) #4
scheglov
https://codereview.chromium.org/2708353008/diff/1/pkg/analysis_server/test/src/plugin/notification_manager_test.dart File pkg/analysis_server/test/src/plugin/notification_manager_test.dart (right): https://codereview.chromium.org/2708353008/diff/1/pkg/analysis_server/test/src/plugin/notification_manager_test.dart#newcode57 pkg/analysis_server/test/src/plugin/notification_manager_test.dart:57: server.AnalysisService.FOLDING: new Set.from([fileA, fileB]) On 2017/02/23 20:07:48, Brian Wilkerson ...
3 years, 9 months ago (2017-02-23 20:26:09 UTC) #5
Brian Wilkerson
3 years, 9 months ago (2017-02-23 20:31:20 UTC) #7
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
37c585e84235a53039bdb1c0671299628c67baeb (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698