Make it safe to initialize the notificationManager in server

pkg/analysis_server/test/src/plugin/notification_manager_test.dart

 // Copyright (c) 2017, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 import 'package:analysis_server/plugin/protocol/protocol.dart' as server;
 import 'package:analysis_server/src/channel/channel.dart';
 import 'package:analysis_server/src/plugin/notification_manager.dart';
 import 'package:analyzer/file_system/memory_file_system.dart';
 import 'package:analyzer_plugin/protocol/protocol.dart' as plugin;
 import 'package:analyzer_plugin/protocol/protocol_constants.dart' as plugin;
@@ skipping 36 matching lines @@
         new plugin.AnalysisErrorsParams(fileA, [pluginError1, pluginError2]);
     manager.handlePluginNotification('a', params.toNotification());
 
     server.AnalysisError serverError1 = serverAnalysisError(0, 0, file: fileA);
     server.AnalysisError serverError2 = serverAnalysisError(3, 4, file: fileA);
     _verifyErrors(fileA, [serverError1, serverError2]);
   }
 
   void test_handlePluginNotification_folding() {
     manager.setSubscriptions({
-      server.AnalysisService.FOLDING: [fileA, fileB]
+      server.AnalysisService.FOLDING: new Set.from([fileA, fileB])

[scheglov, 2017/02/23 20:02:43]

Or [fileA, fileB].toSet()

[Brian Wilkerson, 2017/02/23 20:07:48]

Do you have a significant preference?

[scheglov, 2017/02/23 20:26:09]

No.
It just feel a bit better to have a sequence of invocations instead of "new".

     });
     plugin.FoldingRegion pluginRegion1 = pluginFoldingRegion(10, 3);
     plugin.FoldingRegion pluginRegion2 = pluginFoldingRegion(20, 6);
     plugin.AnalysisFoldingParams params =
         new plugin.AnalysisFoldingParams(fileA, [pluginRegion1, pluginRegion2]);
     manager.handlePluginNotification('a', params.toNotification());
 
     server.FoldingRegion serverRegion1 = serverFoldingRegion(10, 3);
     server.FoldingRegion serverRegion2 = serverFoldingRegion(20, 6);
     _verifyFoldingRegions(fileA, [serverRegion1, serverRegion2]);
   }
 
   void test_handlePluginNotification_highlights() {
     manager.setSubscriptions({
-      server.AnalysisService.HIGHLIGHTS: [fileA, fileB]
+      server.AnalysisService.HIGHLIGHTS: new Set.from([fileA, fileB])
     });
     plugin.HighlightRegion pluginRegion1 = pluginHighlightRegion(10, 3);
     plugin.HighlightRegion pluginRegion2 = pluginHighlightRegion(20, 6);
     plugin.AnalysisHighlightsParams params =
         new plugin.AnalysisHighlightsParams(
             fileA, [pluginRegion1, pluginRegion2]);
 
     server.HighlightRegion serverRegion1 = serverHighlightRegion(10, 3);
     server.HighlightRegion serverRegion2 = serverHighlightRegion(20, 6);
     manager.handlePluginNotification('a', params.toNotification());
     _verifyHighlightRegions(fileA, [serverRegion1, serverRegion2]);
   }
 
   void test_handlePluginNotification_naviation() {
     manager.setSubscriptions({
-      server.AnalysisService.NAVIGATION: [fileA, fileB]
+      server.AnalysisService.NAVIGATION: new Set.from([fileA, fileB])
     });
     plugin.AnalysisNavigationParams pluginParams =
         pluginNavigationParams(0, 0, file: fileA);
     manager.handlePluginNotification('a', pluginParams.toNotification());
 
     server.AnalysisNavigationParams serverParams =
         serverNavigationParams(0, 0, file: fileA);
     _verifyNavigationParams(serverParams);
   }
 
   void test_handlePluginNotification_occurences() {
     manager.setSubscriptions({
-      server.AnalysisService.OCCURRENCES: [fileA, fileB]
+      server.AnalysisService.OCCURRENCES: new Set.from([fileA, fileB])
     });
     plugin.Occurrences pluginOccurrences1 = pluginOccurrences(0, 0);
     plugin.Occurrences pluginOccurrences2 = pluginOccurrences(5, 7);
     plugin.AnalysisOccurrencesParams params =
         new plugin.AnalysisOccurrencesParams(
             fileA, [pluginOccurrences1, pluginOccurrences2]);
 
     server.Occurrences serverOccurrences1 = serverOccurrences(0, 0);
     server.Occurrences serverOccurrences2 = serverOccurrences(5, 7);
     manager.handlePluginNotification('a', params.toNotification());
     _verifyOccurrences(fileA, [serverOccurrences1, serverOccurrences2]);
   }
 
   void test_handlePluginNotification_outline() {
     manager.setSubscriptions({
-      server.AnalysisService.OUTLINE: [fileA, fileB]
+      server.AnalysisService.OUTLINE: new Set.from([fileA, fileB])
     });
     plugin.Outline pluginOutline1 = pluginOutline(0, 0);
     plugin.AnalysisOutlineParams params =
         new plugin.AnalysisOutlineParams(fileA, [pluginOutline1]);
     manager.handlePluginNotification('a', params.toNotification());
 
     server.Outline serverOutline1 = serverOutline(0, 0);
     _verifyOutlines(fileA, serverOutline1);
   }
 
@@ skipping 35 matching lines @@
   }
 
   void test_recordFoldingRegions_noSubscription() {
     server.FoldingRegion region = serverFoldingRegion(10, 5);
     manager.recordFoldingRegions('a', fileA, [region]);
     expect(channel.sentNotification, isNull);
   }
 
   void test_recordFoldingRegions_withSubscription() {
     manager.setSubscriptions({
-      server.AnalysisService.FOLDING: [fileA, fileB]
+      server.AnalysisService.FOLDING: new Set.from([fileA, fileB])
     });
     //
     // Regions should be reported when they are recorded.
     //
     server.FoldingRegion region1 = serverFoldingRegion(10, 3);
     server.FoldingRegion region2 = serverFoldingRegion(20, 6);
     manager.recordFoldingRegions('a', fileA, [region1, region2]);
     _verifyFoldingRegions(fileA, [region1, region2]);
     //
     // Regions from different plugins should be cumulative.
@@ skipping 18 matching lines @@
   }
 
   void test_recordHighlightRegions_noSubscription() {
     server.HighlightRegion region = serverHighlightRegion(10, 5);
     manager.recordHighlightRegions('a', fileA, [region]);
     expect(channel.sentNotification, isNull);
   }
 
   void test_recordHighlightRegions_withSubscription() {
     manager.setSubscriptions({
-      server.AnalysisService.HIGHLIGHTS: [fileA, fileB]
+      server.AnalysisService.HIGHLIGHTS: new Set.from([fileA, fileB])
     });
     //
     // Regions should be reported when they are recorded.
     //
     server.HighlightRegion region1 = serverHighlightRegion(10, 3);
     server.HighlightRegion region2 = serverHighlightRegion(20, 6);
     manager.recordHighlightRegions('a', fileA, [region1, region2]);
     _verifyHighlightRegions(fileA, [region1, region2]);
     //
     // Regions from different plugins should be cumulative.
@@ skipping 19 matching lines @@
 
   void test_recordNavigationParams_noSubscription() {
     server.AnalysisNavigationParams params =
         serverNavigationParams(0, 0, file: fileA);
     manager.recordNavigationParams('a', fileA, params);
     expect(channel.sentNotification, isNull);
   }
 
   void test_recordNavigationParams_withSubscription() {
     manager.setSubscriptions({
-      server.AnalysisService.NAVIGATION: [fileA, fileB]
+      server.AnalysisService.NAVIGATION: new Set.from([fileA, fileB])
     });
     //
     // Parameters should be reported when they are recorded.
     //
     server.AnalysisNavigationParams params1 =
         serverNavigationParams(0, 0, file: fileA);
     manager.recordNavigationParams('a', fileA, params1);
     _verifyNavigationParams(params1);
     //
     // Parameters from different plugins should be cumulative.
@@ skipping 47 matching lines @@
   }
 
   void test_recordOccurrences_noSubscription() {
     server.Occurrences occurrences = serverOccurrences(0, 0);
     manager.recordOccurrences('a', fileA, [occurrences]);
     expect(channel.sentNotification, isNull);
   }
 
   void test_recordOccurrences_withSubscription() {
     manager.setSubscriptions({
-      server.AnalysisService.OCCURRENCES: [fileA, fileB]
+      server.AnalysisService.OCCURRENCES: new Set.from([fileA, fileB])
     });
     //
     // Occurrences should be reported when they are recorded.
     //
     server.Occurrences occurrences1 = serverOccurrences(0, 0);
     server.Occurrences occurrences2 = serverOccurrences(5, 7);
     manager.recordOccurrences('a', fileA, [occurrences1, occurrences2]);
     _verifyOccurrences(fileA, [occurrences1, occurrences2]);
     //
     // Occurrences from different plugins should be cumulative.
@@ skipping 22 matching lines @@
     manager.recordOutlines('a', fileA, [outline]);
     expect(channel.sentNotification, isNull);
   }
 
   @failingTest
   void test_recordOutlines_withSubscription() {
     fail('The outline handling needs to be re-worked slightly');
     // TODO(brianwilkerson) Figure out outlines. What should we do when merge
     // cannot produce a single outline?
     manager.setSubscriptions({
-      server.AnalysisService.OUTLINE: [fileA, fileB]
+      server.AnalysisService.OUTLINE: new Set.from([fileA, fileB])
     });
     //
     // Outlines should be reported when they are recorded.
     //
     server.Outline outline1 = serverOutline(0, 0);
     server.Outline outline2 = serverOutline(5, 7);
     manager.recordOutlines('a', fileA, [outline1, outline2]);
     // TODO(brianwilkerson) Figure out how to test this.
 //    _verifyOutlines(fileA, [outline1, outline2]);
     //
@@ skipping 117 matching lines @@
   @override
   void sendNotification(server.Notification notification) {
     sentNotification = notification;
   }
 
   @override
   void sendResponse(server.Response response) {
     fail('Unexpected invocation of sendResponse');
   }
 }