Remove ArcSessionManager::SetShelfDelegateForTesting.

Remove ArcSessionManager::SetShelfDelegateForTesting.

This CL removes the injecting method for testing.
Instead, in testing, use WmShell::SetShelfDelegateForTesting,
only when needed.

BUG=657687
BUG=b/31079732
TEST=Ran trybots.

Review-Url: https://codereview.chromium.org/2708353007
Cr-Commit-Position: refs/heads/master@{#452771}
Committed: https://chromium.googlesource.com/chromium/src/+/a3397e3e75e6338d188b713f36593c54c0b2b469

[hidehiko, 2017-02-23 18:26:15]

The CQ bit was checked by hidehiko@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-23 18:26:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-23 19:05:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-23 19:05:29]

Dry run: This issue passed the CQ dry run.

[hidehiko, 2017-02-23 19:07:31]

hidehiko@chromium.org changed reviewers:
+ lhchavez@chromium.org, skuhne@chromium.org

[hidehiko, 2017-02-23 19:07:32]

PTAL.

lhchavez@: c/b/c/arc OWNER
skuhne@: c/b/ui/ash/launcher OWNER

[Luis Héctor Chávez, 2017-02-23 19:23:09]

lgtm

https://codereview.chromium.org/2708353007/diff/1/chrome/browser/ui/ash/launc...
File chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc
(right):

https://codereview.chromium.org/2708353007/diff/1/chrome/browser/ui/ash/launc...
chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc:3642:
// Inject launcher_controller_ as ShelfDelegate to verify the behavior
nit: |launch_controller_|, "behavior of removing"

[Mr4D (OOO till 08-26), 2017-02-24 03:59:39]

lgtm

[hidehiko, 2017-02-24 05:42:12]

Thank you for review. Submitting.

https://codereview.chromium.org/2708353007/diff/1/chrome/browser/ui/ash/launc...
File chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc
(right):

https://codereview.chromium.org/2708353007/diff/1/chrome/browser/ui/ash/launc...
chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc:3642:
// Inject launcher_controller_ as ShelfDelegate to verify the behavior
On 2017/02/23 19:23:09, Luis Héctor Chávez wrote:
> nit: |launch_controller_|, "behavior of removing"

Done.

[hidehiko, 2017-02-24 05:42:15]

The CQ bit was checked by hidehiko@chromium.org

[hidehiko, 2017-02-24 05:42:15]

The patchset sent to the CQ was uploaded after l-g-t-m from
lhchavez@chromium.org, skuhne@chromium.org
Link to the patchset: https://codereview.chromium.org/2708353007/#ps40001
(title: "address comments")

[commit-bot: I haz the power, 2017-02-24 05:42:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-24 06:19:51]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1487914935002660,
"parent_rev": "7fc83944d69fe093a586a55bf4591f47b023f548", "commit_rev":
"a3397e3e75e6338d188b713f36593c54c0b2b469"}

[commit-bot: I haz the power, 2017-02-24 06:20:46]

Description was changed from

==========
Remove ArcSessionManager::SetShelfDelegateForTesting.

This CL removes the injecting method for testing.
Instead, in testing, use WmShell::SetShelfDelegateForTesting,
only when needed.

BUG=657687
BUG=b/31079732
TEST=Ran trybots.
==========

to

==========
Remove ArcSessionManager::SetShelfDelegateForTesting.

This CL removes the injecting method for testing.
Instead, in testing, use WmShell::SetShelfDelegateForTesting,
only when needed.

BUG=657687
BUG=b/31079732
TEST=Ran trybots.

Review-Url: https://codereview.chromium.org/2708353007
Cr-Commit-Position: refs/heads/master@{#452771}
Committed:
https://chromium.googlesource.com/chromium/src/+/a3397e3e75e6338d188b713f3659...
==========

[commit-bot: I haz the power, 2017-02-24 06:20:49]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/a3397e3e75e6338d188b713f3659...