Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Issue 2708353004: Propagate color space from the container to the codec. (Closed)

Created:
3 years, 10 months ago by hubbe
Modified:
3 years, 10 months ago
Reviewers:
Tom Sepez, jbauman, ccameron
CC:
chromium-reviews, posciak+watch_chromium.org, feature-media-reviews_chromium.org, piman+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Propagate color space from the container to the codec. This lets the codec tag and convert frames better. BUG=682416 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2708353004 Cr-Commit-Position: refs/heads/master@{#452295} Committed: https://chromium.googlesource.com/chromium/src/+/ed091c8f4cba0ef8f9580ad19ddd65b7bdc3bd35

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -7 lines) Patch
M media/filters/gpu_video_decoder.cc View 1 chunk +1 line, -0 lines 0 comments Download
M media/filters/h264_parser.cc View 1 chunk +1 line, -6 lines 0 comments Download
M media/gpu/dxva_video_decode_accelerator_win.cc View 2 chunks +6 lines, -1 line 0 comments Download
M media/gpu/ipc/common/media_param_traits_macros.h View 2 chunks +2 lines, -0 lines 0 comments Download
M media/video/video_decode_accelerator.h View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (11 generated)
hubbe
3 years, 10 months ago (2017-02-22 22:27:53 UTC) #4
ccameron
lgtm
3 years, 10 months ago (2017-02-22 22:29:51 UTC) #6
jbauman
lgtm
3 years, 10 months ago (2017-02-22 23:00:14 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2708353004/1
3 years, 10 months ago (2017-02-22 23:07:04 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/370695)
3 years, 10 months ago (2017-02-22 23:18:54 UTC) #12
hubbe
+tsepez for security review
3 years, 10 months ago (2017-02-22 23:38:21 UTC) #14
Tom Sepez
lgtm
3 years, 10 months ago (2017-02-22 23:46:41 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2708353004/1
3 years, 10 months ago (2017-02-22 23:54:02 UTC) #17
commit-bot: I haz the power
3 years, 10 months ago (2017-02-23 00:14:37 UTC) #20
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ed091c8f4cba0ef8f9580ad19ddd...

Powered by Google App Engine
This is Rietveld 408576698