Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2708333002:
Restore FSP API's read tests. (Closed)
|
Created:
3 years, 10 months ago by mtomasz Modified:
3 years, 9 months ago Reviewers:
benwells CC:
chromium-reviews, extensions-reviews_chromium.org, yamaguchi+watch_chromium.org, oka+watch_chromium.org, oshima+watch_chromium.org, fukino+watch_chromium.org, chromium-apps-reviews_chromium.org, davemoore+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRestore FSP API's read tests.
The CL regressing this test is reverted. See: crbug.com/2682163002
TBR=benwells
TEST=Test passes.
BUG=691449
Review-Url: https://codereview.chromium.org/2708333002
Cr-Commit-Position: refs/heads/master@{#453567}
Committed: https://chromium.googlesource.com/chromium/src/+/d3499037df8da2c29581bb74f1a3c252921432b0
Patch Set 1 #
Messages
Total messages: 17 (12 generated)
Description was changed from ========== Restore FSP API's read tests. TEST=Test passes. BUG=691449 ========== to ========== Restore FSP API's read tests. The CL regressing this test is reverted. See: crbug.com/2682163002 TEST=Test passes. BUG=691449 ==========
The CQ bit was checked by mtomasz@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by mtomasz@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. Committers are members of the group "project-chromium-committers". Note that this has nothing to do with OWNERS files.
Description was changed from ========== Restore FSP API's read tests. The CL regressing this test is reverted. See: crbug.com/2682163002 TEST=Test passes. BUG=691449 ========== to ========== Restore FSP API's read tests. The CL regressing this test is reverted. See: crbug.com/2682163002 TBR=benwells TEST=Test passes. BUG=691449 ==========
mtomasz@chromium.org changed reviewers: + benwells@chromium.org
The CQ bit was checked by mtomasz@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
@benwells: TBR.
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1488277779216980, "parent_rev":
"eebafb273136b1407c2a9bba936ee41ca5da73e7", "commit_rev":
"d3499037df8da2c29581bb74f1a3c252921432b0"}
Message was sent while issue was closed.
Description was changed from ========== Restore FSP API's read tests. The CL regressing this test is reverted. See: crbug.com/2682163002 TBR=benwells TEST=Test passes. BUG=691449 ========== to ========== Restore FSP API's read tests. The CL regressing this test is reverted. See: crbug.com/2682163002 TBR=benwells TEST=Test passes. BUG=691449 Review-Url: https://codereview.chromium.org/2708333002 Cr-Commit-Position: refs/heads/master@{#453567} Committed: https://chromium.googlesource.com/chromium/src/+/d3499037df8da2c29581bb74f1a3... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/d3499037df8da2c29581bb74f1a3... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
