Android: Make sure temporary scripts are deleted from the device

Android: Make sure temporary scripts are deleted from the device

Once we're done using a temporary file, we should delete it. Otherwise
the files pile up and the linear search to find an unused one takes
longer and longer.

This patch also cleans up the previously leaked temporary files from the
bots.

BUG=371148
R=bulach@chromium.org, jbudorick@chromium.org, yfriedman@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269094

[Sami, 2014-05-08 15:14:36]

https://codereview.chromium.org/270833004/diff/1/build/android/pylib/android_...
File build/android/pylib/android_commands.py (right):

https://codereview.chromium.org/270833004/diff/1/build/android/pylib/android_...
build/android/pylib/android_commands.py:1904: self.EnableAdbRoot
This line makes me say hmm...

[bulach, 2014-05-08 15:22:23]

thanks sami!

John has a fairly similar fix on its way on the CQ:

https://codereview.chromium.org/272713002/

yours have a "finally" block that craig suggested.
perhaps we should wait for his to get in, then rebase yours?

[bulach, 2014-05-08 15:25:03]

forgot to say, lgtm % nit, but please wait for john's review. thanks!!

https://codereview.chromium.org/270833004/diff/1/build/android/pylib/android_...
File build/android/pylib/android_commands.py (right):

https://codereview.chromium.org/270833004/diff/1/build/android/pylib/android_...
build/android/pylib/android_commands.py:1904: self.EnableAdbRoot
On 2014/05/08 15:14:36, Sami wrote:
> This line makes me say hmm...

my bad, I didn't spot this.. :(
 https://codereview.chromium.org/197883005

yes, it should be a function call ()

[jbudorick, 2014-05-08 15:37:24]

lgtm. I was planning to do something like this after my other patch lands.

https://codereview.chromium.org/270833004/diff/1/build/android/pylib/android_...
File build/android/pylib/android_commands.py (right):

https://codereview.chromium.org/270833004/diff/1/build/android/pylib/android_...
build/android/pylib/android_commands.py:1163: # TODO(skyostil): Remove this once
it has been through all the bots.
I'm not sure I like this idea, but I suppose this will guarantee that all of the
relevant bots get wiped.

[Sami, 2014-05-08 15:57:11]

https://codereview.chromium.org/270833004/diff/1/build/android/pylib/android_...
File build/android/pylib/android_commands.py (right):

https://codereview.chromium.org/270833004/diff/1/build/android/pylib/android_...
build/android/pylib/android_commands.py:1163: # TODO(skyostil): Remove this once
it has been through all the bots.
On 2014/05/08 15:37:25, jbudorick wrote:
> I'm not sure I like this idea, but I suppose this will guarantee that all of
the
> relevant bots get wiped.

Yeah, AFAIK we don't have any easy way to run these commands on all bots
automatically, so I opted to this. Other suggestions welcome.

[Yaron, 2014-05-08 17:08:16]

lgtm

https://codereview.chromium.org/270833004/diff/1/build/android/pylib/android_...
File build/android/pylib/android_commands.py (right):

https://codereview.chromium.org/270833004/diff/1/build/android/pylib/android_...
build/android/pylib/android_commands.py:1163: # TODO(skyostil): Remove this once
it has been through all the bots.
On 2014/05/08 15:57:11, Sami wrote:
> On 2014/05/08 15:37:25, jbudorick wrote:
> > I'm not sure I like this idea, but I suppose this will guarantee that all of
> the
> > relevant bots get wiped.
> 
> Yeah, AFAIK we don't have any easy way to run these commands on all bots
> automatically, so I opted to this. Other suggestions welcome.

I think it's the easiest way to clean up the current mess. +1 for doing it
temporarily

[Sami, 2014-05-08 17:32:12]

The CQ bit was checked by skyostil@chromium.org

[commit-bot: I haz the power, 2014-05-08 17:34:34]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/skyostil@chromium.org/270833004/40001

[commit-bot: I haz the power, 2014-05-08 20:50:56]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  android_aosp on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/7...)
  android_chromium_gn_compile_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_c...)
  android_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/bui...)
  android_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg/builds/18...)
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
  ios_dbg_simulator on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_dbg_simulator/bui...)
  ios_rel_device on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device/builds...)
  ios_rel_device_ninja on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device_ninja/...)
  linux_chromium_chromeos_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_clang_...)
  linux_chromium_gn_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_gn_rel...)
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)
  mac_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_compile_...)
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)
  win_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_compile_...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)

[commit-bot: I haz the power, 2014-05-08 20:58:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-08 20:58:58]

Try jobs failed on following builders:
  android_chromium_gn_compile_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_c...)
  android_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/bui...)
  android_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg/builds/18...)
  ios_dbg_simulator on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_dbg_simulator/bui...)
  ios_rel_device on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device/builds...)
  ios_rel_device_ninja on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device_ninja/...)
  linux_chromium_chromeos_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_clang_...)
  linux_chromium_gn_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_gn_rel...)
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)

[Yaron, 2014-05-08 22:24:27]

Committed patchset #3 manually as r269094 (tree was closed).