[Telementry][Android] Only copy changed or missing files of profile

[Telementry][Android] Only copy changed or missing files of profile

Copying the files of a profile, even within a device, can be painfully
slow. To speed this up only copy changed files, and delete new files.

BUG=350032
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=256954

[bulach, 2014-03-13 17:22:57]

lgtm, thanks! just some small suggestions:

https://codereview.chromium.org/197883005/diff/1/build/android/pylib/android_...
File build/android/pylib/android_commands.py (right):

https://codereview.chromium.org/197883005/diff/1/build/android/pylib/android_...
build/android/pylib/android_commands.py:1813: logging.info("In
EfficientDeviceDirectoryCopy %s %s" % (source, dest))
nit: s/"/'/

also, s/%/,/ 
that is, logging.info takes a format and a vararg.

https://codereview.chromium.org/197883005/diff/1/build/android/pylib/android_...
build/android/pylib/android_commands.py:1814: script = """
would it make sense to have this in a separate file rather than embedded here?

https://codereview.chromium.org/197883005/diff/1/build/android/pylib/android_...
build/android/pylib/android_commands.py:1847: copy_if_older "$f"
indent

https://codereview.chromium.org/197883005/diff/1/build/android/pylib/android_...
build/android/pylib/android_commands.py:1886: out = self.RunShellCommand("sh %s
%s %s" % (temp_script_file, source, dest),
nit: s/"/'/

https://codereview.chromium.org/197883005/diff/1/build/android/pylib/android_...
build/android/pylib/android_commands.py:1893: logging.info('[%s]> %s',
device_repr, line)
I think logging is already hooked up to have a device prefix when running with
multiple devices?

https://codereview.chromium.org/197883005/diff/1/tools/telemetry/telemetry/co...
File tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py
(right):

https://codereview.chromium.org/197883005/diff/1/tools/telemetry/telemetry/co...
tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py:91: #
save the lib symbolic link
nit: this comment seems a bit out of place..

[aberent, 2014-03-13 18:32:44]

https://codereview.chromium.org/197883005/diff/1/build/android/pylib/android_...
File build/android/pylib/android_commands.py (right):

https://codereview.chromium.org/197883005/diff/1/build/android/pylib/android_...
build/android/pylib/android_commands.py:1814: script = """
On 2014/03/13 17:22:57, bulach wrote:
> would it make sense to have this in a separate file rather than embedded here?

Done.

https://codereview.chromium.org/197883005/diff/1/build/android/pylib/android_...
build/android/pylib/android_commands.py:1847: copy_if_older "$f"
On 2014/03/13 17:22:57, bulach wrote:
> indent

Done.

https://codereview.chromium.org/197883005/diff/1/build/android/pylib/android_...
build/android/pylib/android_commands.py:1886: out = self.RunShellCommand("sh %s
%s %s" % (temp_script_file, source, dest),
On 2014/03/13 17:22:57, bulach wrote:
> nit: s/"/'/

Done.

https://codereview.chromium.org/197883005/diff/1/build/android/pylib/android_...
build/android/pylib/android_commands.py:1893: logging.info('[%s]> %s',
device_repr, line)
On 2014/03/13 17:22:57, bulach wrote:
> I think logging is already hooked up to have a device prefix when running with
> multiple devices?

No, the device is added by RunShellCommand, but that only adds it to the command
run by RunShellCommand.

https://codereview.chromium.org/197883005/diff/1/tools/telemetry/telemetry/co...
File tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py
(right):

https://codereview.chromium.org/197883005/diff/1/tools/telemetry/telemetry/co...
tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py:91: #
save the lib symbolic link
On 2014/03/13 17:22:57, bulach wrote:
> nit: this comment seems a bit out of place..

Done.

[aberent, 2014-03-13 18:33:00]

The CQ bit was checked by aberent@chromium.org

[commit-bot: I haz the power, 2014-03-13 18:35:53]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/aberent@chromium.org/197883005/20001

[commit-bot: I haz the power, 2014-03-13 19:16:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-13 19:16:20]

Retried try job too often on chromium_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

[aberent, 2014-03-13 20:24:40]

The CQ bit was checked by aberent@chromium.org

[commit-bot: I haz the power, 2014-03-13 20:26:01]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/aberent@chromium.org/197883005/40001

[commit-bot: I haz the power, 2014-03-13 23:58:49]

Change committed as 256954