Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issue 2708323002: Revert of [ResourceScheduler] Yield after starting several requests (Closed)

Created:
3 years, 10 months ago by mtomasz
Modified:
3 years, 10 months ago
CC:
chromium-reviews, loading-reviews_chromium.org, jam, darin-cc_chromium.org, Randy Smith (Not in Mondays), mmenke
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [ResourceScheduler] Yield after starting several requests (patchset #9 id:240001 of https://codereview.chromium.org/2682163002/ ) Reason for revert: Regresses blob requests making them delayable. Original issue's description: > [ResourceScheduler] Yield after starting several requests > > This CL periodically yields the ResourceScheduler after starting several > requests. This gives existing IO tasks (such as active network requests) a > chance to run between network starts. This should result in less jank and more > interleaved network request tasks. > > BUG=655585 > > Review-Url: https://codereview.chromium.org/2682163002 > Cr-Commit-Position: refs/heads/master@{#449895} > Committed: https://chromium.googlesource.com/chromium/src/+/1a8d5f3805dbae5242cf7dce14df3807344dae37 TBR=csharrison@chromium.org,isherman@chromium.org,jkarlin@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=655585 Review-Url: https://codereview.chromium.org/2708323002 Cr-Commit-Position: refs/heads/master@{#451946} Committed: https://chromium.googlesource.com/chromium/src/+/a9757ebf44c92e009d075322ad35f008b0bfa1ad

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -190 lines) Patch
M content/browser/loader/resource_scheduler.h View 1 chunk +0 lines, -5 lines 0 comments Download
M content/browser/loader/resource_scheduler.cc View 11 chunks +4 lines, -77 lines 0 comments Download
M content/browser/loader/resource_scheduler_unittest.cc View 4 chunks +0 lines, -89 lines 0 comments Download
M testing/variations/fieldtrial_testing_config.json View 1 chunk +0 lines, -19 lines 0 comments Download

Messages

Total messages: 18 (7 generated)
mtomasz
Created Revert of [ResourceScheduler] Yield after starting several requests
3 years, 10 months ago (2017-02-22 03:52:52 UTC) #1
mtomasz
This CL broke FSP API tests. It was incorrectly assumed that the FSP API tests ...
3 years, 10 months ago (2017-02-22 03:53:38 UTC) #2
mtomasz
Reverting, as this CL may break user files.
3 years, 10 months ago (2017-02-22 03:55:01 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2708323002/1
3 years, 10 months ago (2017-02-22 03:56:01 UTC) #7
Charlie Harrison
Hey mtomasz, Can you point to a bug or resource showing the failure and why ...
3 years, 10 months ago (2017-02-22 04:39:08 UTC) #8
Charlie Harrison
Oops, just noticed you posted this information on the original CL :) sorry for the ...
3 years, 10 months ago (2017-02-22 04:39:52 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_tsan_rel_ng/builds/19486)
3 years, 10 months ago (2017-02-22 07:29:11 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2708323002/1
3 years, 10 months ago (2017-02-22 07:33:22 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/a9757ebf44c92e009d075322ad35f008b0bfa1ad
3 years, 10 months ago (2017-02-22 09:10:06 UTC) #16
jkarlin
Thanks for pointing out the break in contract, I'll fix it so that non http(s) ...
3 years, 10 months ago (2017-02-22 14:19:04 UTC) #17
jkarlin
3 years, 10 months ago (2017-02-22 15:14:22 UTC) #18
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2711633003/ by jkarlin@chromium.org.

The reason for reverting is: Adds a check for http(s) before yielding the
scheduler..

Powered by Google App Engine
This is Rietveld 408576698