Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(487)

Issue 2708283002: [DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files. (Closed)

Created:
3 years, 10 months ago by ymzhang1
Modified:
3 years, 9 months ago
CC:
chromium-reviews, asanka, aboxhall+watch_chromium.org, nektar+watch_chromium.org, jam, yuzo+watch_chromium.org, je_julie, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files. We are adding COMPONENT/TEAM information into OWNERS file. Please help us to verify the added TEAM/COMPONENT or suggest the correct TEAM/COMPONENT in your OWNERS files. Thanks. Proposal to add TEAM/COMPONENT information into OWNERS files http://bit.ly/add-team-component-proposal Proposal about how to get suggested component for directory. http://bit.ly/directory-mapping-proposal TEAM-COMPONENT mapping http://bit.ly/component-team-mapping Additional Information: Component lists https://bugs.chromium.org/p/chromium/adminComponents BUG=679905 Review-Url: https://codereview.chromium.org/2708283002 Cr-Commit-Position: refs/heads/master@{#453095} Committed: https://chromium.googlesource.com/chromium/src/+/74c09cc3128a36e8a705731f16716b820ecdd754

Patch Set 1 #

Total comments: 36

Patch Set 2 : update component #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -2 lines) Patch
M chrome/android/java/res/OWNERS View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/compositor/OWNERS View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/compositor/overlays/strip/OWNERS View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/compositor/scene_layer/OWNERS View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/share/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/compositor/OWNERS View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/android/junit/src/org/chromium/chrome/browser/compositor/OWNERS View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/app/android/OWNERS View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/android/OWNERS View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/android/compositor/OWNERS View 1 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/download/OWNERS View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/android/tab_contents/OWNERS View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/android/tab_model/OWNERS View 1 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/download/OWNERS View 1 1 chunk +2 lines, -0 lines 0 comments Download
M content/public/android/java/res/OWNERS View 1 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/android_opengl/OWNERS View 1 1 chunk +3 lines, -1 line 0 comments Download
M ui/android/OWNERS View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
ymzhang1
Hello, We are adding COMPONENT/TEAM information into OWNERS file. Would you mind helping us to ...
3 years, 10 months ago (2017-02-22 00:48:11 UTC) #2
David Trainor- moved to gerrit
On 2017/02/22 00:48:11, ymzhang1 wrote: > Hello, > > We are adding COMPONENT/TEAM information into ...
3 years, 10 months ago (2017-02-23 03:35:33 UTC) #3
ymzhang1
On 2017/02/23 03:35:33, David Trainor wrote: > On 2017/02/22 00:48:11, ymzhang1 wrote: > > Hello, ...
3 years, 9 months ago (2017-02-23 17:37:21 UTC) #4
David Trainor- moved to gerrit
Sorry for the delays. Updated the components. There's a bug (695941) tracking the creation of ...
3 years, 9 months ago (2017-02-24 18:16:05 UTC) #5
ymzhang1
Thank you very much for the helpful comments and creating the new component! https://codereview.chromium.org/2708283002/diff/1/chrome/android/OWNERS File ...
3 years, 9 months ago (2017-02-24 18:56:26 UTC) #7
David Trainor- moved to gerrit
lgtm
3 years, 9 months ago (2017-02-25 05:13:55 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2708283002/40001
3 years, 9 months ago (2017-02-25 15:33:40 UTC) #10
commit-bot: I haz the power
3 years, 9 months ago (2017-02-25 16:15:00 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/74c09cc3128a36e8a705731f1671...

Powered by Google App Engine
This is Rietveld 408576698