Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Issue 2708243002: [IntersectionObserver] Get rid of spurious console warning. (Closed)

Created:
3 years, 10 months ago by szager1
Modified:
3 years, 10 months ago
CC:
blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[IntersectionObserver] Get rid of spurious console warning. This previously may have been useful console warning to alert developers when they called observe() on a target without adding it to the DOM tree. However, now that observe() always results in an initial notification, this console warning becomes more noisy than useful. BUG=693166 R=mlamouri@chromium.org,ojan@chromium.org Review-Url: https://codereview.chromium.org/2708243002 Cr-Commit-Position: refs/heads/master@{#452109} Committed: https://chromium.googlesource.com/chromium/src/+/6ba8baa98a274d2bb9aef1d95bdb237255f09ba8

Patch Set 1 #

Patch Set 2 : Remove unused variable #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -28 lines) Patch
D third_party/WebKit/LayoutTests/intersection-observer/containing-block-warning.html View 1 chunk +0 lines, -10 lines 0 comments Download
D third_party/WebKit/LayoutTests/intersection-observer/containing-block-warning-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/IntersectionObserver.cpp View 1 1 chunk +2 lines, -16 lines 0 comments Download

Messages

Total messages: 21 (10 generated)
szager1
3 years, 10 months ago (2017-02-21 22:29:05 UTC) #1
mlamouri (slow - plz ping)
lgtm
3 years, 10 months ago (2017-02-21 22:39:22 UTC) #2
ojan
lgtm
3 years, 10 months ago (2017-02-21 23:10:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2708243002/1
3 years, 10 months ago (2017-02-21 23:13:24 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/236611)
3 years, 10 months ago (2017-02-21 23:39:04 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2708243002/20001
3 years, 10 months ago (2017-02-21 23:52:44 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromeos_amd64-generic_chromium_compile_only_ng on ...
3 years, 10 months ago (2017-02-22 01:55:57 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2708243002/20001
3 years, 10 months ago (2017-02-22 02:06:53 UTC) #14
commit-bot: I haz the power
Exceeded global retry quota
3 years, 10 months ago (2017-02-22 04:09:47 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2708243002/20001
3 years, 10 months ago (2017-02-22 16:29:03 UTC) #18
commit-bot: I haz the power
3 years, 10 months ago (2017-02-22 17:35:39 UTC) #21
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/6ba8baa98a274d2bb9aef1d95bdb...

Powered by Google App Engine
This is Rietveld 408576698