Issue 270823004: Oilpan: Prepare to move FormAssociatedElement to Oilpan heap, part 2.

Issue 270823004: Oilpan: Prepare to move FormAssociatedElement to Oilpan heap, part 2. (Closed)

Created:
6 years, 7 months ago by tkent

Modified:
6 years, 7 months ago

Reviewers:
keishi, oilpan-reviews, haraken, zerny-chromium, Mads Ager (chromium)

CC:
blink-reviews, dglazkov+blink, blink-reviews-html_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Oilpan: Prepare to move FormAssociatedElement to Oilpan heap, part 2. Replace FormAssociatedElement raw pointers with Member<>. - Make FormAttributeTargetObserver GarbageCollectedFinalized in order to make FormAttributeTargetObserver::m_element traceable. - Define a typedef for WillBeHeapVector<RawPtrWillBeMember<FormAssociatedElement>>. The raw name is long and the type is used in many places. BUG=357163 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=173723

Patch Set 1 #

Total comments: 2

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+67 lines, -45 lines)			Patch
M	Source/core/html/FormAssociatedElement.h	View	2 chunks	+4 lines, -2 lines	0 comments	Download
M	Source/core/html/FormAssociatedElement.cpp	View	4 chunks	+10 lines, -7 lines	2 comments	Download
M	Source/core/html/HTMLFieldSetElement.h	View	2 chunks	+3 lines, -2 lines	0 comments	Download
M	Source/core/html/HTMLFieldSetElement.cpp	View	2 chunks	+9 lines, -1 line	0 comments	Download
M	Source/core/html/HTMLFormControlsCollection.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	Source/core/html/HTMLFormControlsCollection.cpp	View	5 chunks	+5 lines, -5 lines	0 comments	Download
M	Source/core/html/HTMLFormElement.h	View	4 chunks	+4 lines, -4 lines	0 comments	Download
M	Source/core/html/HTMLFormElement.cpp	View	12 chunks	+20 lines, -12 lines	0 comments	Download
M	Source/core/html/forms/FormController.cpp	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	Source/web/WebFormElement.cpp	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	Source/web/WebSearchableFormData.cpp	View	3 chunks	+6 lines, -6 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

haraken

LGTM https://codereview.chromium.org/270823004/diff/1/Source/core/html/FormAssociatedElement.cpp File Source/core/html/FormAssociatedElement.cpp (right): https://codereview.chromium.org/270823004/diff/1/Source/core/html/FormAssociatedElement.cpp#newcode39 Source/core/html/FormAssociatedElement.cpp:39: // FIXME: Oilpan: IdTargetObserver should be on-heap. Yes, ...

6 years, 7 months ago (2014-05-09 05:02:03 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tkent@chromium.org/270823004/1

6 years, 7 months ago (2014-05-09 05:18:03 UTC) #5

Mads Ager (chromium)

lgtm2 https://codereview.chromium.org/270823004/diff/1/Source/core/html/FormAssociatedElement.cpp File Source/core/html/FormAssociatedElement.cpp (right): https://codereview.chromium.org/270823004/diff/1/Source/core/html/FormAssociatedElement.cpp#newcode39 Source/core/html/FormAssociatedElement.cpp:39: // FIXME: Oilpan: IdTargetObserver should be on-heap. On ...

6 years, 7 months ago (2014-05-09 05:46:30 UTC) #7

Message was sent while issue was closed.

lgtm

Expand Messages | Collapse Messages