Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(686)

Unified Diff: Source/core/html/HTMLFormElement.h

Issue 270823004: Oilpan: Prepare to move FormAssociatedElement to Oilpan heap, part 2. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/html/HTMLFormElement.h
diff --git a/Source/core/html/HTMLFormElement.h b/Source/core/html/HTMLFormElement.h
index c8b55440f4f7a4592becfd2fa32449ca1cded2c0..5ea8a7a4a5ef80ffa93d709ec87d3bf5e586f03d 100644
--- a/Source/core/html/HTMLFormElement.h
+++ b/Source/core/html/HTMLFormElement.h
@@ -49,6 +49,7 @@ class HTMLFormElement FINAL : public HTMLElement {
public:
static PassRefPtrWillBeRawPtr<HTMLFormElement> create(Document&);
virtual ~HTMLFormElement();
+ virtual void trace(Visitor*) OVERRIDE;
PassRefPtr<HTMLCollection> elements();
void getNamedElements(const AtomicString&, Vector<RefPtr<Element> >&);
@@ -110,7 +111,7 @@ public:
RadioButtonGroupScope& radioButtonGroupScope() { return m_radioButtonGroupScope; }
- const Vector<FormAssociatedElement*>& associatedElements() const;
+ const FormAssociatedElement::List& associatedElements() const;
const Vector<HTMLImageElement*>& imageElements();
void anonymousNamedGetter(const AtomicString& name, bool&, RefPtr<RadioNodeList>&, bool&, RefPtr<Element>&);
@@ -138,7 +139,7 @@ private:
void scheduleFormSubmission(PassRefPtr<FormSubmission>);
- void collectAssociatedElements(Node& root, Vector<FormAssociatedElement*>&) const;
+ void collectAssociatedElements(Node& root, FormAssociatedElement::List&) const;
void collectImageElements(Node& root, Vector<HTMLImageElement*>&);
// Returns true if the submission should proceed.
@@ -161,8 +162,7 @@ private:
RadioButtonGroupScope m_radioButtonGroupScope;
// Do not access m_associatedElements directly. Use associatedElements() instead.
- // FIXME: Oilpan: m_associatedElements should be HeapVector<Member<>>.
- Vector<FormAssociatedElement*> m_associatedElements;
+ FormAssociatedElement::List m_associatedElements;
// Do not access m_imageElements directly. Use imageElements() instead.
Vector<HTMLImageElement*> m_imageElements;
WeakPtrFactory<HTMLFormElement> m_weakPtrFactory;

Powered by Google App Engine
This is Rietveld 408576698