Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 270823002: Fix "implements in RHS file" (Closed)

Created:
6 years, 7 months ago by Nils Barth (inactive)
Modified:
6 years, 7 months ago
Reviewers:
haraken
CC:
blink-reviews, blink-reviews-bindings_chromium.org, arv+blink, abarth-chromium
Visibility:
Public.

Description

Fix "implements in RHS file" Recent CL broke run-bindings-tests on my machine: Move modules-dependent IDL statements out of core by supporting 'implements' in RHS interface https://codereview.chromium.org/270573005/ This is due to depending on order of files; this is fixed by doing the moving/merging in a separate, global phase (which we're already doing). Also: * Adds a test case. * Fixes unaddressed nits. R=haraken BUG=358074 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=173613

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -20 lines) Patch
M Source/bindings/scripts/compute_interfaces_info.py View 3 chunks +14 lines, -4 lines 2 comments Download
M Source/bindings/scripts/utilities.py View 1 chunk +26 lines, -15 lines 0 comments Download
M Source/bindings/tests/idls/TestImplements2.idl View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/bindings/tests/idls/TestInterface.idl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Nils Barth (inactive)
https://codereview.chromium.org/270823002/diff/1/Source/bindings/scripts/compute_interfaces_info.py File Source/bindings/scripts/compute_interfaces_info.py (left): https://codereview.chromium.org/270823002/diff/1/Source/bindings/scripts/compute_interfaces_info.py#oldcode197 Source/bindings/scripts/compute_interfaces_info.py:197: interface_info = interfaces_info[left_interface_name] This fails with KeyError: 'Window' ...on ...
6 years, 7 months ago (2014-05-08 06:31:44 UTC) #1
haraken
LGTM
6 years, 7 months ago (2014-05-08 06:56:16 UTC) #2
Nils Barth (inactive)
The CQ bit was checked by nbarth@chromium.org
6 years, 7 months ago (2014-05-08 06:59:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/270823002/1
6 years, 7 months ago (2014-05-08 06:59:55 UTC) #4
commit-bot: I haz the power
6 years, 7 months ago (2014-05-08 07:50:02 UTC) #5
Message was sent while issue was closed.
Change committed as 173613

Powered by Google App Engine
This is Rietveld 408576698