Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 2708193002: Media Controls: cache the minimum width in order to reduce incorrect width usage. (Closed)

Created:
3 years, 10 months ago by mlamouri (slow - plz ping)
Modified:
3 years, 10 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

Media Controls: cache the minimum width in order to reduce incorrect width usage. The width of media controls buttons depends on the platform (Android vs desktop) and is known by looking at the layout of the play button or the overflow menu button. This technique has limitations because it requires one layout to happen which might take a long time depending on when the controls have been toggled. The new solution consist of saving the minimum width so that as soon as the controls discovered the right value, they should no longer appear broken. BUG=663931 R=zqzhang@chromium.org Review-Url: https://codereview.chromium.org/2704013002 Cr-Commit-Position: refs/heads/master@{#451611} (cherry picked from commit e5399d9f871fab1ea1e7b061125106199ee0545a) Review-Url: https://codereview.chromium.org/2708193002 . Cr-Commit-Position: refs/branch-heads/2987@{#623} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/b5715d877525dce29848b72e309692d7ab735417

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -19 lines) Patch
A third_party/WebKit/LayoutTests/media/controls/buttons-after-reset.html View 1 chunk +26 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/media/controls/buttons-after-reset-expected.html View 1 chunk +12 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/shadow/MediaControls.cpp View 2 chunks +16 lines, -19 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
mlamouri (slow - plz ping)
3 years, 10 months ago (2017-02-21 21:10:21 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b5715d877525dce29848b72e309692d7ab735417.

Powered by Google App Engine
This is Rietveld 408576698