Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2708183002:
[Payments] Format expiration month dropdown key format to the stored format in Autofill (Closed)
|
Created:
3 years, 10 months ago by gogerald1 Modified:
3 years, 10 months ago Reviewers:
please use gerrit instead CC:
chromium-reviews, rouslan+payments_chromium.org, sebsg+paymentswatch_chromium.org, gogerald+paymentswatch_chromium.org, agrieve+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionFormat expiration month dropdown key format to the stored format in Autofill
July is formatted to 07 instead of 7
BUG=693635
Review-Url: https://codereview.chromium.org/2708183002
Cr-Commit-Position: refs/heads/master@{#451863}
Committed: https://chromium.googlesource.com/chromium/src/+/3d0ee9842f3600ac4fb3489c2ea6bafd85d6dee8
Patch Set 1 #
Messages
Total messages: 18 (10 generated)
Description was changed from ========== Format expiration month dropdown key format to the stored format in Autofill BUG= ========== to ========== Format expiration month dropdown key format to the stored format in Autofill BUG=693635 ==========
Description was changed from ========== Format expiration month dropdown key format to the stored format in Autofill BUG=693635 ========== to ========== Format expiration month dropdown key format to the stored format in Autofill July is formatted to 07 instead of 7 BUG=693635 ==========
gogerald@chromium.org changed reviewers: + rouslan@chromium.org
Hi rouslan@, PTAL,
LGTM. Let's merge it to M-57.
The CQ bit was checked by gogerald@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by gogerald@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by gogerald@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1487724299770350, "parent_rev":
"c2717e0b70e4fe483cbabf5065cac58c7bc5871a", "commit_rev":
"3d0ee9842f3600ac4fb3489c2ea6bafd85d6dee8"}
Message was sent while issue was closed.
Description was changed from ========== Format expiration month dropdown key format to the stored format in Autofill July is formatted to 07 instead of 7 BUG=693635 ========== to ========== Format expiration month dropdown key format to the stored format in Autofill July is formatted to 07 instead of 7 BUG=693635 Review-Url: https://codereview.chromium.org/2708183002 Cr-Commit-Position: refs/heads/master@{#451863} Committed: https://chromium.googlesource.com/chromium/src/+/3d0ee9842f3600ac4fb3489c2ea6... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/3d0ee9842f3600ac4fb3489c2ea6... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
