Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 2708173002: idl_parser: Add support for the record<K, V> WebIDL type. (Closed)

Created:
3 years, 10 months ago by Raphael Kubo da Costa (rakuco)
Modified:
3 years, 10 months ago
Reviewers:
haraken, bashi, Yuki
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

idl_parser: Add support for the record<K, V> WebIDL type. This CL is the first step towards fully supporting it in the bindings code. It merely makes the IDL parser aware of the new type (namely, the "RecordType" symbol) by updating the grammar to match the current WebIDL version. The devil is in the details though: the IDL parser was also unaware of the "StringType" symbol that comprises ByteStrings, DOMStrings and USVStrings (the only allowed key types for records), so most of the patch is just updating existing tests to consider those 3 string types StringTypes, not PrimitiveTypes. BUG=685754 R=bashi@chromium.org,haraken@chromium.org,yukishiino@chromium.org Review-Url: https://codereview.chromium.org/2708173002 Cr-Commit-Position: refs/heads/master@{#451970} Committed: https://chromium.googlesource.com/chromium/src/+/4bec0d7dc53aa20a83fbd1b4e6bf097b5ff4dded

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+126 lines, -32 lines) Patch
M third_party/WebKit/Source/bindings/scripts/idl_definitions.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/idl_parser/idl_lexer.py View 3 chunks +3 lines, -1 line 2 comments Download
M tools/idl_parser/idl_parser.py View 4 chunks +22 lines, -5 lines 0 comments Download
M tools/idl_parser/idl_ppapi_lexer.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/idl_parser/idl_ppapi_parser.py View 1 chunk +12 lines, -0 lines 0 comments Download
M tools/idl_parser/test_lexer/keywords.in View 2 chunks +2 lines, -0 lines 0 comments Download
M tools/idl_parser/test_parser/dictionary_web.idl View 3 chunks +3 lines, -3 lines 0 comments Download
M tools/idl_parser/test_parser/exception_web.idl View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/idl_parser/test_parser/interface_web.idl View 12 chunks +62 lines, -17 lines 0 comments Download
M tools/idl_parser/test_parser/typedef_web.idl View 2 chunks +17 lines, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
Raphael Kubo da Costa (rakuco)
PTAL. This is part 1 of ? for the aforementioned bug; this bit only makes ...
3 years, 10 months ago (2017-02-21 19:37:47 UTC) #1
haraken
LGTM https://codereview.chromium.org/2708173002/diff/1/tools/idl_parser/idl_lexer.py File tools/idl_parser/idl_lexer.py (right): https://codereview.chromium.org/2708173002/diff/1/tools/idl_parser/idl_lexer.py#newcode107 tools/idl_parser/idl_lexer.py:107: 'USVString' : 'USVSTRING', alphabetical order?
3 years, 10 months ago (2017-02-21 23:36:09 UTC) #2
Yuki
LGTM. https://codereview.chromium.org/2708173002/diff/1/tools/idl_parser/idl_lexer.py File tools/idl_parser/idl_lexer.py (right): https://codereview.chromium.org/2708173002/diff/1/tools/idl_parser/idl_lexer.py#newcode107 tools/idl_parser/idl_lexer.py:107: 'USVString' : 'USVSTRING', On 2017/02/21 23:36:09, haraken wrote: ...
3 years, 10 months ago (2017-02-22 07:44:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2708173002/1
3 years, 10 months ago (2017-02-22 08:11:47 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2708173002/1
3 years, 10 months ago (2017-02-22 09:50:48 UTC) #8
commit-bot: I haz the power
3 years, 10 months ago (2017-02-22 10:13:27 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/4bec0d7dc53aa20a83fbd1b4e6bf...

Powered by Google App Engine
This is Rietveld 408576698