Android: Android studio single module per target

Android: Android studio single module per target

Existing users can continue to split modules by gn targets by passing
--split-project to generate_gradle.py, although that flag will not
receive the same maintenance going forward, consider it deprecated.

This coalesces java and resource dependencies into the same build.gradle
file for each apk and junit target specified (test apks still get folded
into the apk_under_test target).

Speeds up sync/builds by 10x to 1-3 seconds. Paves the way for using
more of android studio's build steps, since they'll now take 1-3 seconds
rather than 10+ seconds each time.

BUG=620034
Review-Url: https://codereview.chromium.org/2708133002
Cr-Commit-Position: refs/heads/master@{#453257}
Committed: https://chromium.googlesource.com/chromium/src/+/543908d37bb29cad0925a6553cb6a7261b222133

[Peter Wen, 2017-02-21 17:05:08]

Description was changed from

==========
Android: Android studio single module per target

Existing users can continue to split modules by gn targets by passing
--split-project to generate_gradle.py.

This coalesces java and resource dependencies into the same build.gradle
file for each apk and junit target specified (test apks still get folded
into the apk_under_test target).

Speeds up sync/builds by 10x to 1-3 seconds. Paves the way for using
more of android studio's build steps, since they'll now take 1-3 seconds
rather than 10+ seconds each time.

BUG=620034
==========

to

==========
Android: Android studio single module per target

Existing users can continue to split modules by gn targets by passing
--split-project to generate_gradle.py, although that flag will not
receive the same maintenance going forward, consider it deprecated.

This coalesces java and resource dependencies into the same build.gradle
file for each apk and junit target specified (test apks still get folded
into the apk_under_test target).

Speeds up sync/builds by 10x to 1-3 seconds. Paves the way for using
more of android studio's build steps, since they'll now take 1-3 seconds
rather than 10+ seconds each time.

BUG=620034
==========

[Peter Wen, 2017-02-21 17:07:39]

wnwen@chromium.org changed reviewers:
+ agrieve@chromium.org

[Peter Wen, 2017-02-21 17:07:39]

PTAL

[agrieve, 2017-02-21 17:52:05]

lgtm

https://codereview.chromium.org/2708133002/diff/20001/build/android/gradle/ge...
File build/android/gradle/generate_gradle.py (right):

https://codereview.chromium.org/2708133002/diff/20001/build/android/gradle/ge...
build/android/gradle/generate_gradle.py:335: variables =
collections.defaultdict(list)
nit: some variables can be non-lists, so using a defaultdict doesn't make a lot
of sense to me. Seems you could change most of the +=s to just =s anyways?

https://codereview.chromium.org/2708133002/diff/20001/build/android/gradle/ge...
build/android/gradle/generate_gradle.py:637:
parser.add_argument('--use-gradle-process-resources',
I'm guessing that non-split projects will currently break with
--use-gradle-process-resources because of the issue of resource package names.
If so, maybe add an assert that --split-projects is always used when
--use-gradle-process-resources is used (and maybe a TODO to fix it up)

[Peter Wen, 2017-02-21 19:45:51]

The CQ bit was checked by wnwen@chromium.org to run a CQ dry run

[Peter Wen, 2017-02-21 19:46:51]

The CQ bit was unchecked by wnwen@chromium.org

[commit-bot: I haz the power, 2017-02-21 19:46:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Peter Wen, 2017-02-21 19:46:54]

The CQ bit was checked by wnwen@chromium.org

[Peter Wen, 2017-02-21 19:46:54]

The patchset sent to the CQ was uploaded after l-g-t-m from agrieve@chromium.org
Link to the patchset: https://codereview.chromium.org/2708133002/#ps40001
(title: "Remove default dict and add assert for incompatible args")

[commit-bot: I haz the power, 2017-02-21 19:47:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Peter Wen, 2017-02-21 20:07:13]

The CQ bit was unchecked by wnwen@chromium.org

[Peter Wen, 2017-02-21 21:02:50]

The CQ bit was checked by wnwen@chromium.org

[commit-bot: I haz the power, 2017-02-21 21:04:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-21 21:49:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-21 21:49:59]

Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)

[Peter Wen, 2017-02-27 16:50:15]

The CQ bit was checked by wnwen@chromium.org

[Peter Wen, 2017-02-27 16:50:15]

The patchset sent to the CQ was uploaded after l-g-t-m from agrieve@chromium.org
Link to the patchset: https://codereview.chromium.org/2708133002/#ps60001
(title: "Rebase")

[commit-bot: I haz the power, 2017-02-27 16:50:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-27 18:09:33]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1488214215026410,
"parent_rev": "9d6c0f9ad3a5d10c6ffc45119308026be3ec9a86", "commit_rev":
"543908d37bb29cad0925a6553cb6a7261b222133"}

[commit-bot: I haz the power, 2017-02-27 18:10:12]

Description was changed from

==========
Android: Android studio single module per target

Existing users can continue to split modules by gn targets by passing
--split-project to generate_gradle.py, although that flag will not
receive the same maintenance going forward, consider it deprecated.

This coalesces java and resource dependencies into the same build.gradle
file for each apk and junit target specified (test apks still get folded
into the apk_under_test target).

Speeds up sync/builds by 10x to 1-3 seconds. Paves the way for using
more of android studio's build steps, since they'll now take 1-3 seconds
rather than 10+ seconds each time.

BUG=620034
==========

to

==========
Android: Android studio single module per target

Existing users can continue to split modules by gn targets by passing
--split-project to generate_gradle.py, although that flag will not
receive the same maintenance going forward, consider it deprecated.

This coalesces java and resource dependencies into the same build.gradle
file for each apk and junit target specified (test apks still get folded
into the apk_under_test target).

Speeds up sync/builds by 10x to 1-3 seconds. Paves the way for using
more of android studio's build steps, since they'll now take 1-3 seconds
rather than 10+ seconds each time.

BUG=620034

Review-Url: https://codereview.chromium.org/2708133002
Cr-Commit-Position: refs/heads/master@{#453257}
Committed:
https://chromium.googlesource.com/chromium/src/+/543908d37bb29cad0925a6553cb6...
==========

[commit-bot: I haz the power, 2017-02-27 18:10:13]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/543908d37bb29cad0925a6553cb6...