Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 270813003: Reland r172943 "Make CSSFontFace::willUseFontData() load fonts with unicode-range" (Closed)

Created:
6 years, 7 months ago by Kunihiko Sakamoto
Modified:
6 years, 7 months ago
Reviewers:
dglazkov, eae
CC:
blink-reviews, jamesr, blink-reviews-rendering, krit, jbroman, zoltan1, blink-reviews-css, eae+blinkwatch, ed+blinkwatch_opera.com, leviw+renderwatch, danakj, dglazkov+blink, Rik, apavlov+blink_chromium.org, jchaffraix+rendering, darktears, pdr., rune+blink, Stephen Chennney, rwlbuis, enne (OOO)
Visibility:
Public.

Description

Reland r172943 "Make CSSFontFace::willUseFontData() load fonts with unicode-range" The original patch was reverted in r173234, because the chagne exposed a hidden bug of SVG fonts (crbug.com/369633). That bug is being addressed in https://codereview.chromium.org/271633002/ so I'm relanding this patch. BUG=369633 > Make CSSFontFace::willUseFontData() load fonts with unicode-range > > Before this patch CSSFontFace::willUseFontData() loads font faces that > have no unicode-range. Since font faces with no unicode-range tends to > be used as fallback font of segmented font family, this behavior leads > to unnecessary font downloads. > > This patch makes willUseFontData() loads the first unloaded font face > whose unicode-range intersects with given text. That check does not > need to be 100% precise (false negative is ok), so it only checks the > first character of the text, for speed. > > TEST=fast/css/font-face-unicode-range-overlap-load.html > BUG=247920, 246492 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=172943 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=173699

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -25 lines) Patch
M LayoutTests/fast/css/font-face-unicode-range-overlap-load.html View 3 chunks +14 lines, -1 line 0 comments Download
M LayoutTests/fast/css/font-face-unicode-range-overlap-load-expected.txt View 1 chunk +5 lines, -1 line 0 comments Download
M Source/core/css/CSSFontFace.h View 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/css/CSSFontFace.cpp View 3 chunks +14 lines, -10 lines 0 comments Download
M Source/core/css/CSSFontSelector.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSFontSelector.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/css/CSSSegmentedFontFace.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSSegmentedFontFace.cpp View 1 chunk +7 lines, -3 lines 0 comments Download
M Source/core/rendering/RenderText.cpp View 1 chunk +4 lines, -1 line 0 comments Download
M Source/platform/fonts/Font.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/fonts/Font.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/platform/fonts/FontSelector.h View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Kunihiko Sakamoto
6 years, 7 months ago (2014-05-08 06:31:19 UTC) #1
Kunihiko Sakamoto
Hi reviewers, I'd really like to get this in M36. Could you please take a ...
6 years, 7 months ago (2014-05-09 01:01:51 UTC) #2
dglazkov
lgtm
6 years, 7 months ago (2014-05-09 01:05:26 UTC) #3
Kunihiko Sakamoto
The CQ bit was checked by ksakamoto@chromium.org
6 years, 7 months ago (2014-05-09 01:12:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ksakamoto@chromium.org/270813003/1
6 years, 7 months ago (2014-05-09 01:14:59 UTC) #5
commit-bot: I haz the power
6 years, 7 months ago (2014-05-09 01:29:09 UTC) #6
Message was sent while issue was closed.
Change committed as 173699

Powered by Google App Engine
This is Rietveld 408576698