Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2708043003:
Remove DumpWithoutCrashing() from RFHI::SetNavigationHandle (Closed)
DescriptionRemove DumpWithoutCrashing() from RFHI::SetNavigationHandle
Semi-related bug is marked fixed. Part of trying to rationalize all
calls to DumpWithoutCrashing().
R=clamy@chromium.org
BUG=621856, 694688
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
Review-Url: https://codereview.chromium.org/2708043003
Cr-Commit-Position: refs/heads/master@{#452309}
Committed: https://chromium.googlesource.com/chromium/src/+/669ebe761301d962d5c0540bb7d8e2cfe836a81e
Patch Set 1 #
Messages
Total messages: 20 (12 generated)
Description was changed from ========== Remove DumpWithoutCrashing() from RFHI::SetNavigationHandle Semi-related bug is marked fixed. Part of trying to rationalize all calls to DumpWithoutCrashing(). R=clamy@chromium.org BUG=621856,694688 ========== to ========== Remove DumpWithoutCrashing() from RFHI::SetNavigationHandle Semi-related bug is marked fixed. Part of trying to rationalize all calls to DumpWithoutCrashing(). R=clamy@chromium.org BUG=621856,694688 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation ==========
Hi, is it OK to remove this? It looks like the somewhat related bug is marked fixed. If it's still useful I can convert it to a CHECK(), but DumpWithoutCrashing()s tend to just cause jank if they actually get hit, and then no one looks at the reports anyway.
The CQ bit was checked by scottmg@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
Thanks for the cleanup! Lgtm.
The CQ bit was checked by scottmg@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_site_isolation on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_site_isol...)
The CQ bit was checked by scottmg@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_site_isolation on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_site_isol...)
The CQ bit was checked by scottmg@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1487803423513000, "parent_rev":
"51dd8015de2619e1ef86f01f215ffe2dee297a6e", "commit_rev":
"669ebe761301d962d5c0540bb7d8e2cfe836a81e"}
Message was sent while issue was closed.
Description was changed from ========== Remove DumpWithoutCrashing() from RFHI::SetNavigationHandle Semi-related bug is marked fixed. Part of trying to rationalize all calls to DumpWithoutCrashing(). R=clamy@chromium.org BUG=621856,694688 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation ========== to ========== Remove DumpWithoutCrashing() from RFHI::SetNavigationHandle Semi-related bug is marked fixed. Part of trying to rationalize all calls to DumpWithoutCrashing(). R=clamy@chromium.org BUG=621856,694688 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2708043003 Cr-Commit-Position: refs/heads/master@{#452309} Committed: https://chromium.googlesource.com/chromium/src/+/669ebe761301d962d5c0540bb7d8... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/669ebe761301d962d5c0540bb7d8... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
