Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Issue 2708043002: ParsedContentType parameter name matching should be case insensitive (Closed)

Created:
3 years, 10 months ago by yhirano
Modified:
3 years, 10 months ago
Reviewers:
kinuko
CC:
chromium-reviews, blink-reviews, kinuko+watch, tyoshino (SeeGerritForStatus)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ParsedContentType parameter name matching should be case insensitive As specified in RFC (and as written in the comment), MIME parameter attribute matching should be always case-insensitive. BUG=689731 Review-Url: https://codereview.chromium.org/2708043002 Cr-Commit-Position: refs/heads/master@{#452403} Committed: https://chromium.googlesource.com/chromium/src/+/55d2881ba47ca3ba4eb6fe93f08ad98613777c5f

Patch Set 1 #

Patch Set 2 : done #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -7 lines) Patch
M third_party/WebKit/Source/platform/network/ParsedContentType.cpp View 1 2 chunks +8 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/network/ParsedContentTypeTest.cpp View 2 chunks +15 lines, -5 lines 0 comments Download

Messages

Total messages: 21 (15 generated)
yhirano
3 years, 10 months ago (2017-02-21 08:28:04 UTC) #4
kinuko
lgtm
3 years, 10 months ago (2017-02-21 11:47:30 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2708043002/1
3 years, 10 months ago (2017-02-22 15:03:11 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/370089) linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, ...
3 years, 10 months ago (2017-02-22 15:05:35 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2708043002/20001
3 years, 10 months ago (2017-02-23 05:07:51 UTC) #18
commit-bot: I haz the power
3 years, 10 months ago (2017-02-23 05:16:40 UTC) #21
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/55d2881ba47ca3ba4eb6fe93f08a...

Powered by Google App Engine
This is Rietveld 408576698