Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 2707993004: Selection API: Fix a null pointer dereference in addRange(). (Closed)

Created:
3 years, 10 months ago by tkent
Modified:
3 years, 10 months ago
Reviewers:
yoichio, yosin_UTC9
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Selection API: Fix a null pointer dereference in addRange(). FrameSelection::firstRange() can be null if the cached Range points invisible elements. BUG=694414 Review-Url: https://codereview.chromium.org/2707993004 Cr-Commit-Position: refs/heads/master@{#451954} Committed: https://chromium.googlesource.com/chromium/src/+/ca0cbc0427aa4c5a60e00ce75a004e44347056eb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -1 line) Patch
A third_party/WebKit/LayoutTests/editing/selection/addrange-crash.html View 1 chunk +11 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/editing/DOMSelection.cpp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
tkent
yoichio@, yosin@, would you review this please?
3 years, 10 months ago (2017-02-22 05:39:46 UTC) #4
yosin_UTC9
lgtm
3 years, 10 months ago (2017-02-22 06:31:52 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2707993004/1
3 years, 10 months ago (2017-02-22 07:36:56 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-22 09:29:01 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ca0cbc0427aa4c5a60e00ce75a00...

Powered by Google App Engine
This is Rietveld 408576698