Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 2707973005: Remove Media.UnderflowCount, add Media.UnderflowDuration for MSE. (Closed)

Created:
3 years, 10 months ago by DaleCurtis
Modified:
3 years, 10 months ago
CC:
apacible+watch_chromium.org, asvitkine+watch_chromium.org, chromium-reviews, erickung+watch_chromium.org, feature-media-reviews_chromium.org, miu+watch_chromium.org, xjz+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove Media.UnderflowCount, add Media.UnderflowDuration for MSE. The counts can be inferred by the sample volume for UnderflowDuration, so there's no need to track both. BUG=641633 TEST=manually checked histograms in chrome://histograms. Review-Url: https://codereview.chromium.org/2707973005 Cr-Commit-Position: refs/heads/master@{#452113} Committed: https://chromium.googlesource.com/chromium/src/+/4f6d14dbe9482803495eaee9377c0f2816f8f2d9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -19 lines) Patch
M media/blink/webmediaplayer_impl.h View 2 chunks +5 lines, -2 lines 0 comments Download
M media/blink/webmediaplayer_impl.cc View 6 chunks +17 lines, -16 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 2 chunks +13 lines, -1 line 0 comments Download

Messages

Total messages: 17 (8 generated)
DaleCurtis
3 years, 10 months ago (2017-02-21 23:07:45 UTC) #2
Ilya Sherman
LGTM
3 years, 10 months ago (2017-02-21 23:14:10 UTC) #3
chcunningham
lgtm
3 years, 10 months ago (2017-02-21 23:30:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2707973005/1
3 years, 10 months ago (2017-02-21 23:37:03 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromeos_amd64-generic_chromium_compile_only_ng on ...
3 years, 10 months ago (2017-02-22 01:40:25 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2707973005/1
3 years, 10 months ago (2017-02-22 03:25:38 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/369701)
3 years, 10 months ago (2017-02-22 07:41:47 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2707973005/1
3 years, 10 months ago (2017-02-22 16:52:41 UTC) #14
commit-bot: I haz the power
3 years, 10 months ago (2017-02-22 17:43:02 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/4f6d14dbe9482803495eaee9377c...

Powered by Google App Engine
This is Rietveld 408576698