Remove blacklist on .innerHTML and .outerHTML

Remove blacklist on .innerHTML and .outerHTML

The blacklist was stored in HTMLElement::ieForbidsInsertHTML(),
used to disallow set inner/outerHTML on these elements and determine
whether the tag should be serailized with end tag or not.

The current spec doesn't have any blocklist on them, so the
blocklists on .innerHTML, .outerHTML and createContextualFragment()
are all removed in this change.

During the serialization, the spec [1] have a list of tag names
which should skip the end tag, the serializers now using it instead of
using the HTMLElement::ieForbidsInsertHTML().

This commit also fix a bug in serializeNodesWithNamespaces(), which
always append the end tag even it is serialized as html document and
the tag is in the list mentioned above.

Around 180 failed tests will be passed after this change.

[1] https://www.w3.org/TR/DOM-Parsing/

BUG=679069
Review-Url: https://codereview.chromium.org/2707973002
Cr-Commit-Position: refs/heads/master@{#451961}
Committed: https://chromium.googlesource.com/chromium/src/+/7a581007693d6b482158d03cd6eac849da99bb76

[Sunny, 2017-02-20 17:01:45]

Description was changed from

==========
Remove blacklist on .innerHTML and .outerHTML

The blacklist was stored in HTMLElement::ieForbidsInsertHTML(),
used to disallow set inner/outerHTML on these elements and determine
whether the tag should be serailized with end tag or not.

The current spec doesn't have any blocklist on them, so the
blocklists on .innerHTML, .outerHTML and createContextualFragment()
are all removed in this change.

During the serialization, the spec [1] have a list of tag names
which should skip the end tag, the serializers now using it instead of
using the HTMLElement::ieForbidsInsertHTML().

This commit also fix a bug in serializeNodesWithNamespaces(), which
always append the end tag even it is serialized as html document and
the tag is in the list mentioned above.

Around 180 failed test will be passed after this change.

[1] https://www.w3.org/TR/DOM-Parsing/

BUG=679069
==========

to

==========
Remove blacklist on .innerHTML and .outerHTML

The blacklist was stored in HTMLElement::ieForbidsInsertHTML(),
used to disallow set inner/outerHTML on these elements and determine
whether the tag should be serailized with end tag or not.

The current spec doesn't have any blocklist on them, so the
blocklists on .innerHTML, .outerHTML and createContextualFragment()
are all removed in this change.

During the serialization, the spec [1] have a list of tag names
which should skip the end tag, the serializers now using it instead of
using the HTMLElement::ieForbidsInsertHTML().

This commit also fix a bug in serializeNodesWithNamespaces(), which
always append the end tag even it is serialized as html document and
the tag is in the list mentioned above.

Around 180 failed tests will be passed after this change.

[1] https://www.w3.org/TR/DOM-Parsing/

BUG=679069
==========

[Sunny, 2017-02-20 17:04:27]

ratsunny@gmail.com changed reviewers:
+ tkent@chromium.org

[Sunny, 2017-02-20 17:04:28]

Hi tkent@, could you give a a dry run and answer this question for me? Thanks :D

https://bugs.chromium.org/p/chromium/issues/detail?id=679069#c6

[tkent, 2017-02-20 19:53:03]

The CQ bit was checked by tkent@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-20 19:53:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-20 21:17:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-20 21:17:17]

Dry run: This issue passed the CQ dry run.

[tkent, 2017-02-20 23:36:03]

On 2017/02/20 at 17:04:28, ratsunny wrote:
> Hi tkent@, could you give a a dry run and answer this question for me? Thanks
:D
> 
> https://bugs.chromium.org/p/chromium/issues/detail?id=679069#c6

> 1. Change HTMLElement::ieForbidsInsertHTML() to
HTMLElement::cannotHaveEndTagWhenSerialising(), and keep the reference between
these three files and the function.

I prefer this option.  Having the identical tag lists in multiple files would be
bad for code health.
"shouldSerializeEndTag()" would be a better function name.

[Sunny, 2017-02-21 12:45:30]

On 2017/02/20 23:36:03, tkent wrote:
> On 2017/02/20 at 17:04:28, ratsunny wrote:
> > Hi tkent@, could you give a a dry run and answer this question for me?
Thanks
> :D
> > 
> > https://bugs.chromium.org/p/chromium/issues/detail?id=679069#c6
> 
> > 1. Change HTMLElement::ieForbidsInsertHTML() to
> HTMLElement::cannotHaveEndTagWhenSerialising(), and keep the reference between
> these three files and the function.
> 
> I prefer this option.  Having the identical tag lists in multiple files would
be
> bad for code health.
> "shouldSerializeEndTag()" would be a better function name.

Hi tkent@, PTAL, thanks~

[tkent, 2017-02-21 21:19:46]

The CQ bit was checked by tkent@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-21 21:21:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-21 23:25:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-21 23:25:58]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)

[tkent, 2017-02-22 00:31:55]

https://codereview.chromium.org/2707973002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/editing/serializers/MarkupAccumulator.cpp
(right):

https://codereview.chromium.org/2707973002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/editing/serializers/MarkupAccumulator.cpp:87:
static inline bool elementCannotHaveEndTag(const Node& node) {
Please add |inline| only if it improves user-visible performance.

https://codereview.chromium.org/2707973002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/editing/serializers/MarkupFormatter.cpp
(right):

https://codereview.chromium.org/2707973002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/editing/serializers/MarkupFormatter.cpp:181:
static inline bool elementCannotHaveEndTag(const Node& node) {
Please add |inline| only if it improves user-visible performance.

https://codereview.chromium.org/2707973002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/web/WebFrameSerializerImpl.cpp (right):

https://codereview.chromium.org/2707973002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/web/WebFrameSerializerImpl.cpp:102: using namespace
HTMLNames;
This is unnecessary.

https://codereview.chromium.org/2707973002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/web/WebFrameSerializerImpl.cpp:370: static inline bool
canHaveEndTag(Element* element) {
I don't think we need to introduce new function.

[Sunny, 2017-02-22 04:25:38]

On 2017/02/22 00:31:55, tkent wrote:
>
https://codereview.chromium.org/2707973002/diff/20001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/core/editing/serializers/MarkupAccumulator.cpp
> (right):
> 
>
https://codereview.chromium.org/2707973002/diff/20001/third_party/WebKit/Sour...
> third_party/WebKit/Source/core/editing/serializers/MarkupAccumulator.cpp:87:
> static inline bool elementCannotHaveEndTag(const Node& node) {
> Please add |inline| only if it improves user-visible performance.
> 
>
https://codereview.chromium.org/2707973002/diff/20001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/core/editing/serializers/MarkupFormatter.cpp
> (right):
> 
>
https://codereview.chromium.org/2707973002/diff/20001/third_party/WebKit/Sour...
> third_party/WebKit/Source/core/editing/serializers/MarkupFormatter.cpp:181:
> static inline bool elementCannotHaveEndTag(const Node& node) {
> Please add |inline| only if it improves user-visible performance.
> 
>
https://codereview.chromium.org/2707973002/diff/20001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/web/WebFrameSerializerImpl.cpp (right):
> 
>
https://codereview.chromium.org/2707973002/diff/20001/third_party/WebKit/Sour...
> third_party/WebKit/Source/web/WebFrameSerializerImpl.cpp:102: using namespace
> HTMLNames;
> This is unnecessary.
> 
>
https://codereview.chromium.org/2707973002/diff/20001/third_party/WebKit/Sour...
> third_party/WebKit/Source/web/WebFrameSerializerImpl.cpp:370: static inline
bool
> canHaveEndTag(Element* element) {
> I don't think we need to introduce new function.

All fixed~ PTAL, thanks~

[tkent, 2017-02-22 04:35:55]

The CQ bit was checked by tkent@chromium.org

[tkent, 2017-02-22 04:35:56]

lgtm

[commit-bot: I haz the power, 2017-02-22 04:36:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-22 07:27:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-22 07:27:43]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[tkent, 2017-02-22 07:32:36]

The CQ bit was checked by tkent@chromium.org

[commit-bot: I haz the power, 2017-02-22 07:34:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-22 09:50:42]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1487748756010910,
"parent_rev": "c5608a34fd0112511e9165179a91cdd9277518b2", "commit_rev":
"7a581007693d6b482158d03cd6eac849da99bb76"}

[commit-bot: I haz the power, 2017-02-22 09:51:18]

Description was changed from

==========
Remove blacklist on .innerHTML and .outerHTML

The blacklist was stored in HTMLElement::ieForbidsInsertHTML(),
used to disallow set inner/outerHTML on these elements and determine
whether the tag should be serailized with end tag or not.

The current spec doesn't have any blocklist on them, so the
blocklists on .innerHTML, .outerHTML and createContextualFragment()
are all removed in this change.

During the serialization, the spec [1] have a list of tag names
which should skip the end tag, the serializers now using it instead of
using the HTMLElement::ieForbidsInsertHTML().

This commit also fix a bug in serializeNodesWithNamespaces(), which
always append the end tag even it is serialized as html document and
the tag is in the list mentioned above.

Around 180 failed tests will be passed after this change.

[1] https://www.w3.org/TR/DOM-Parsing/

BUG=679069
==========

to

==========
Remove blacklist on .innerHTML and .outerHTML

The blacklist was stored in HTMLElement::ieForbidsInsertHTML(),
used to disallow set inner/outerHTML on these elements and determine
whether the tag should be serailized with end tag or not.

The current spec doesn't have any blocklist on them, so the
blocklists on .innerHTML, .outerHTML and createContextualFragment()
are all removed in this change.

During the serialization, the spec [1] have a list of tag names
which should skip the end tag, the serializers now using it instead of
using the HTMLElement::ieForbidsInsertHTML().

This commit also fix a bug in serializeNodesWithNamespaces(), which
always append the end tag even it is serialized as html document and
the tag is in the list mentioned above.

Around 180 failed tests will be passed after this change.

[1] https://www.w3.org/TR/DOM-Parsing/

BUG=679069

Review-Url: https://codereview.chromium.org/2707973002
Cr-Commit-Position: refs/heads/master@{#451961}
Committed:
https://chromium.googlesource.com/chromium/src/+/7a581007693d6b482158d03cd6ea...
==========

[commit-bot: I haz the power, 2017-02-22 09:51:19]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/7a581007693d6b482158d03cd6ea...