Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Unified Diff: ios/chrome/browser/ui/omnibox/location_bar_view_ios.h

Issue 2707963002: [ObjC ARC] Converts ios/chrome/browser/ui/omnibox:omnibox_internal to ARC. (Closed)
Patch Set: weaks Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/ui/omnibox/location_bar_view_ios.h
diff --git a/ios/chrome/browser/ui/omnibox/location_bar_view_ios.h b/ios/chrome/browser/ui/omnibox/location_bar_view_ios.h
index 4f47c1709b8694e7399d9bcc5fee0a9609df32b5..35bef16f61c7d18c5ebab6eca3daf181ac409387 100644
--- a/ios/chrome/browser/ui/omnibox/location_bar_view_ios.h
+++ b/ios/chrome/browser/ui/omnibox/location_bar_view_ios.h
@@ -109,8 +109,10 @@ class LocationBarViewIOS : public WebOmniboxEditController {
base::scoped_nsobject<UIButton> clear_text_button_;
std::unique_ptr<OmniboxViewIOS> edit_view_;
base::scoped_nsobject<OmniboxClearButtonBridge> clear_button_bridge_;
rohitrao (ping after 24h) 2017/02/24 13:40:31 We have to use scoped_nsobject here, because it's
stkhapugin 2017/03/01 17:43:58 yes
- OmniboxTextFieldIOS* field_;
- id<LocationBarDelegate> delegate_;
+ __unsafe_unretained OmniboxTextFieldIOS*
+ field_; // Should be __weak but is included from non-ARC code.
rohitrao (ping after 24h) 2017/02/24 13:40:31 Nit: if you move the comment to be on the line abo
stkhapugin 2017/03/01 17:43:58 Done.
+ __unsafe_unretained id<LocationBarDelegate>
+ delegate_; // Should be __weak but is included from non-ARC code.
bool is_showing_placeholder_while_collapsed_;
};

Powered by Google App Engine
This is Rietveld 408576698