Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Unified Diff: ios/chrome/browser/ui/omnibox/location_bar_view_ios.mm

Issue 2707963002: [ObjC ARC] Converts ios/chrome/browser/ui/omnibox:omnibox_internal to ARC. (Closed)
Patch Set: weaks Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/ui/omnibox/location_bar_view_ios.mm
diff --git a/ios/chrome/browser/ui/omnibox/location_bar_view_ios.mm b/ios/chrome/browser/ui/omnibox/location_bar_view_ios.mm
index ae05807ed6461171f91799f674ff35a871eb823d..4e059f2b02ba87f0562a4cd7a05c3f9bd2537a7e 100644
--- a/ios/chrome/browser/ui/omnibox/location_bar_view_ios.mm
+++ b/ios/chrome/browser/ui/omnibox/location_bar_view_ios.mm
@@ -30,6 +30,10 @@
#include "ios/web/public/web_state/web_state.h"
#include "ui/base/l10n/l10n_util.h"
+#if !defined(__has_feature) || !__has_feature(objc_arc)
+#error "This file requires ARC support."
+#endif
+
namespace {
const CGFloat kClearTextButtonWidth = 28;
const CGFloat kClearTextButtonHeight = 28;
@@ -305,7 +309,7 @@ void LocationBarViewIOS::CreateClearTextIcon(bool is_incognito) {
[button addTarget:clear_button_bridge_
action:@selector(clearText)
forControlEvents:UIControlEventTouchUpInside];
- clear_text_button_.reset([button retain]);
+ clear_text_button_.reset(button);
SetA11yLabelAndUiAutomationName(clear_text_button_,
IDS_IOS_ACCNAME_CLEAR_TEXT, @"Clear Text");

Powered by Google App Engine
This is Rietveld 408576698