webstorePrivate: Support an |authuser| property in beginInstallWithManifest3.

webstorePrivate: Support an |authuser| property in beginInstallWithManifest3.

This adds support for an optional |authuser| integer property
in the |details| object passed to beginInstallWithManifest3.
This value is propagated down to the WebstoreInstaller and used
to augment the CRX download request with a standard-ish
|authuser| query parameter corresponding to the index of the
installing user within a multi-login session.

BUG=371100
R=asargent@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269420

[Ken Rockot(use gerrit already), 2014-05-08 01:24:45]

Antony could you please take a look at this as well?

[Ken Rockot(use gerrit already), 2014-05-08 15:51:59]

As with the other CL, I've replaced Resolve with ReplaceComponents here.

[asargent_no_longer_on_chrome, 2014-05-08 16:06:05]

lgtm w/ nits

https://codereview.chromium.org/270793002/diff/20001/chrome/browser/extension...
File chrome/browser/extensions/webstore_installer.cc (right):

https://codereview.chromium.org/270793002/diff/20001/chrome/browser/extension...
chrome/browser/extensions/webstore_installer.cc:89: const char
kAuthUserQueryKey[] = "authuser";
nit: this is duplicated with your other CL - can you put it in a common place? 

(Perhaps chrome/common/extensions/extension_constants.h? Or maybe make it a
public member of this class or ExtensionDownloader?)

https://codereview.chromium.org/270793002/diff/20001/chrome/browser/extension...
chrome/browser/extensions/webstore_installer.cc:170: *url =
url->ReplaceComponents(replacements);
nit: Seems like duplicated code here too - see if you can find a common place
for it

[Ken Rockot(use gerrit already), 2014-05-08 16:18:21]

Thanks. TODOs added for now, as I may have bigger plans for CRX download.

[Ken Rockot(use gerrit already), 2014-05-08 16:18:26]

The CQ bit was checked by rockot@chromium.org

[commit-bot: I haz the power, 2014-05-08 16:22:59]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/rockot@chromium.org/270793002/50001

[Ken Rockot(use gerrit already), 2014-05-08 20:32:16]

The CQ bit was unchecked by rockot@chromium.org

[Ken Rockot(use gerrit already), 2014-05-08 20:53:13]

The CQ bit was checked by rockot@chromium.org

[commit-bot: I haz the power, 2014-05-08 21:00:03]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/rockot@chromium.org/270793002/50001

[Ken Rockot(use gerrit already), 2014-05-08 21:19:09]

The CQ bit was unchecked by rockot@chromium.org

[Ken Rockot(use gerrit already), 2014-05-08 22:01:54]

The CQ bit was checked by rockot@chromium.org

[commit-bot: I haz the power, 2014-05-08 22:08:28]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/rockot@chromium.org/270793002/70001

[commit-bot: I haz the power, 2014-05-09 21:41:42]

Change committed as 269420