chrome/browser/extensions/api/webstore_private/webstore_private_apitest.cc - Issue 270793002: webstorePrivate: Support an |authuser| property in beginInstallWithManifest3.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/webstore_private/webstore_private_apitest.cc

Issue 270793002: webstorePrivate: Support an |authuser| property in beginInstallWithManifest3. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Let authuser pass thru as a string rather than forcing int Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/webstore_private/webstore_private_api.cc ('k') | chrome/browser/extensions/webstore_installer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/webstore_private/webstore_private_apitest.cc

diff --git a/chrome/browser/extensions/api/webstore_private/webstore_private_apitest.cc b/chrome/browser/extensions/api/webstore_private/webstore_private_apitest.cc

index 74ac417b84879df3b31f99d3a0da53a9136054e8..77c8ff198580671d8ee98723173229790e3b620e 100644

--- a/chrome/browser/extensions/api/webstore_private/webstore_private_apitest.cc

+++ b/chrome/browser/extensions/api/webstore_private/webstore_private_apitest.cc

@@ -356,6 +356,7 @@ IN_PROC_BROWSER_TEST_F(ExtensionWebstorePrivateApiTest, MAYBE_BeginInstall) {

EXPECT_EQ(appId, approval->extension_id);

EXPECT_TRUE(approval->use_app_installed_bubble);

EXPECT_FALSE(approval->skip_post_install_ui);

+ EXPECT_EQ("2", approval->authuser);

EXPECT_EQ(browser()->profile(), approval->profile);

approval = WebstorePrivateApi::PopApprovalForTesting(

@@ -363,6 +364,7 @@ IN_PROC_BROWSER_TEST_F(ExtensionWebstorePrivateApiTest, MAYBE_BeginInstall) {

EXPECT_EQ(extensionId, approval->extension_id);

EXPECT_FALSE(approval->use_app_installed_bubble);

EXPECT_FALSE(approval->skip_post_install_ui);

+ EXPECT_TRUE(approval->authuser.empty());

EXPECT_EQ(browser()->profile(), approval->profile);

}