Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 2707903002: [serializer] allow duplicate API external references. (Closed)

Created:
3 years, 10 months ago by Yang
Modified:
3 years, 10 months ago
CC:
v8-reviews_googlegroups.com, Yang
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[serializer] allow duplicate API external references. Due to link-time optimizations functions with same code can be folded into one, resulting in duplicate references. R=jochen@chromium.org, peria@chromium.org BUG=chromium:617892 Review-Url: https://codereview.chromium.org/2707903002 Cr-Commit-Position: refs/heads/master@{#43317} Committed: https://chromium.googlesource.com/v8/v8/+/46290669d1886c2e6ed28e180dd05b6833d7453d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M src/external-reference-table.h View 2 chunks +2 lines, -0 lines 0 comments Download
M src/external-reference-table.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/snapshot/serializer-common.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M test/cctest/test-serialize.cc View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Yang
3 years, 10 months ago (2017-02-20 11:52:47 UTC) #1
jochen (gone - plz use gerrit)
lgtm
3 years, 10 months ago (2017-02-20 11:55:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2707903002/1
3 years, 10 months ago (2017-02-20 12:50:56 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/v8/v8/+/46290669d1886c2e6ed28e180dd05b6833d7453d
3 years, 10 months ago (2017-02-20 12:52:59 UTC) #11
peria
3 years, 10 months ago (2017-02-21 02:54:45 UTC) #12
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698