Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Issue 2707853003: [ObjC ARC] Converts ios/chrome/app:app to ARC. (Closed)

Created:
3 years, 10 months ago by stkhapugin
Modified:
3 years, 10 months ago
Reviewers:
sdefresne
CC:
chromium-reviews, marq+watch_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ObjC ARC] Converts ios/chrome/app:app to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Review-Url: https://codereview.chromium.org/2707853003 Cr-Commit-Position: refs/heads/master@{#451790} Committed: https://chromium.googlesource.com/chromium/src/+/68f99173e266f08546d33fd9e4105ab5ab407366

Patch Set 1 #

Total comments: 4

Patch Set 2 : asdf #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -28 lines) Patch
M ios/chrome/app/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/app/deferred_initialization_runner.mm View 1 7 chunks +22 lines, -20 lines 0 comments Download
M ios/chrome/app/safe_mode_crashing_modules_config.mm View 1 3 chunks +7 lines, -8 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
stkhapugin
ptal
3 years, 10 months ago (2017-02-20 16:17:29 UTC) #4
stkhapugin
s/noyau/sdefresne for faster review. PTAL :)
3 years, 10 months ago (2017-02-21 13:09:14 UTC) #8
sdefresne
lgtm https://codereview.chromium.org/2707853003/diff/1/ios/chrome/app/deferred_initialization_runner.mm File ios/chrome/app/deferred_initialization_runner.mm (right): https://codereview.chromium.org/2707853003/diff/1/ios/chrome/app/deferred_initialization_runner.mm#newcode18 ios/chrome/app/deferred_initialization_runner.mm:18: @interface DeferredInitializationBlock : NSObject { nit: move this ...
3 years, 10 months ago (2017-02-21 14:20:25 UTC) #9
stkhapugin
https://codereview.chromium.org/2707853003/diff/1/ios/chrome/app/deferred_initialization_runner.mm File ios/chrome/app/deferred_initialization_runner.mm (right): https://codereview.chromium.org/2707853003/diff/1/ios/chrome/app/deferred_initialization_runner.mm#newcode18 ios/chrome/app/deferred_initialization_runner.mm:18: @interface DeferredInitializationBlock : NSObject { On 2017/02/21 14:20:25, sdefresne ...
3 years, 10 months ago (2017-02-21 15:47:02 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2707853003/20001
3 years, 10 months ago (2017-02-21 16:03:59 UTC) #13
commit-bot: I haz the power
3 years, 10 months ago (2017-02-21 17:41:35 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/68f99173e266f08546d33fd9e410...

Powered by Google App Engine
This is Rietveld 408576698