[GCM] Add more UMA to GCM

google_apis/gcm/engine/registration_request.cc

Index: google_apis/gcm/engine/registration_request.cc
diff --git a/google_apis/gcm/engine/registration_request.cc b/google_apis/gcm/engine/registration_request.cc
index dd3f3697474b97c9e1b1c274900c4cda6ffd99f4..511bf661cf9ee052999aee5cbfd97263dd404c7f 100644
--- a/google_apis/gcm/engine/registration_request.cc
+++ b/google_apis/gcm/engine/registration_request.cc
@@ -151,11 +151,14 @@ void RegistrationRequest::Start() {
     senders.append(*iter);
   }
   BuildFormEncoding(kSenderKey, senders, &body);
+  UMA_HISTOGRAM_COUNTS("GCM.RegistrationSenderNumber",

[Nicolas Zea, 2014/05/08 21:28:19]

I think RegistrationSenderIdCount is more accurate/readable than SenderNumber.

[jianli, 2014/05/08 21:40:47]

Done.

+                       request_info_.sender_ids.size());
 
   DVLOG(1) << "Performing registration for: " << request_info_.app_id;
   DVLOG(1) << "Registration request: " << body;
   url_fetcher_->SetUploadData(kRegistrationRequestContentType, body);
   recorder_->RecordRegistrationSent(request_info_.app_id, senders);
+  request_start_time_ = base::TimeTicks::Now();
   url_fetcher_->Start();
 }
 
@@ -252,6 +255,12 @@ void RegistrationRequest::OnURLFetchComplete(const net::URLFetcher* source) {
     RecordRegistrationStatusToUMA(status);
   }
 
+  if (status == SUCCESS) {
+    UMA_HISTOGRAM_COUNTS("GCM.RegistrationRetryNumber",

[Nicolas Zea, 2014/05/08 21:28:19]

Number -> Count here too

[jianli, 2014/05/08 21:40:47]

Done.

+                         backoff_entry_.failure_count());
+    UMA_HISTOGRAM_TIMES("GCM.RegistrationCompleteTime",
+                        base::TimeTicks::Now() - request_start_time_);
+  }
   callback_.Run(status, token);
 }