[GCM] Add more UMA to GCM

google_apis/gcm/engine/registration_request.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "google_apis/gcm/engine/registration_request.h"
 
 #include "base/bind.h"
 #include "base/message_loop/message_loop.h"
 #include "base/metrics/histogram.h"
 #include "base/strings/string_number_conversions.h"
@@ skipping 133 matching lines @@
   for (std::vector<std::string>::const_iterator iter =
            request_info_.sender_ids.begin();
        iter != request_info_.sender_ids.end();
        ++iter) {
     DCHECK(!iter->empty());
     if (!senders.empty())
       senders.append(",");
     senders.append(*iter);
   }
   BuildFormEncoding(kSenderKey, senders, &body);
+  UMA_HISTOGRAM_COUNTS("GCM.RegistrationSenderNumber",

[Nicolas Zea, 2014/05/08 21:28:19]

I think RegistrationSenderIdCount is more accurate/readable than SenderNumber.

[jianli, 2014/05/08 21:40:47]

Done.

+                       request_info_.sender_ids.size());
 
   DVLOG(1) << "Performing registration for: " << request_info_.app_id;
   DVLOG(1) << "Registration request: " << body;
   url_fetcher_->SetUploadData(kRegistrationRequestContentType, body);
   recorder_->RecordRegistrationSent(request_info_.app_id, senders);
+  request_start_time_ = base::TimeTicks::Now();
   url_fetcher_->Start();
 }
 
 void RegistrationRequest::RetryWithBackoff(bool update_backoff) {
   if (update_backoff) {
     DCHECK_GT(retries_left_, 0);
     --retries_left_;
     url_fetcher_.reset();
     backoff_entry_.InformOfRequest(false);
   }
@@ skipping 76 matching lines @@
     }
 
     status = REACHED_MAX_RETRIES;
     recorder_->RecordRegistrationResponse(
         request_info_.app_id,
         request_info_.sender_ids,
         status);
     RecordRegistrationStatusToUMA(status);
   }
 
+  if (status == SUCCESS) {
+    UMA_HISTOGRAM_COUNTS("GCM.RegistrationRetryNumber",

[Nicolas Zea, 2014/05/08 21:28:19]

Number -> Count here too

[jianli, 2014/05/08 21:40:47]

Done.

+                         backoff_entry_.failure_count());
+    UMA_HISTOGRAM_TIMES("GCM.RegistrationCompleteTime",
+                        base::TimeTicks::Now() - request_start_time_);
+  }
   callback_.Run(status, token);
 }
 
 }  // namespace gcm