Chromium Code Reviews| Index: google_apis/gcm/engine/unregistration_request.cc |
| diff --git a/google_apis/gcm/engine/unregistration_request.cc b/google_apis/gcm/engine/unregistration_request.cc |
| index 92136bff3f1ed7547521d20930e4fc110b0a99a2..cde3ee3ae91d911e0dc4f3e9da6f9d4a6f8e0adf 100644 |
| --- a/google_apis/gcm/engine/unregistration_request.cc |
| +++ b/google_apis/gcm/engine/unregistration_request.cc |
| @@ -159,6 +159,7 @@ void UnregistrationRequest::Start() { |
| DVLOG(1) << "Performing unregistration for: " << request_info_.app_id; |
| recorder_->RecordUnregistrationSent(request_info_.app_id); |
| + request_start_time_ = base::TimeTicks::Now(); |
| url_fetcher_->Start(); |
| } |
| @@ -204,11 +205,20 @@ void UnregistrationRequest::OnURLFetchComplete(const net::URLFetcher* source) { |
| status == INCORRECT_APP_ID || |
| status == RESPONSE_PARSING_FAILED) { |
| RetryWithBackoff(true); |
| - } else { |
| - // status == SUCCESS || HTTP_NOT_OK || NO_RESPONSE_BODY || |
| - // INVALID_PARAMETERS || UNKNOWN_ERROR |
| - callback_.Run(status); |
| + return; |
| } |
| + |
| + // status == SUCCESS || HTTP_NOT_OK || NO_RESPONSE_BODY || |
| + // INVALID_PARAMETERS || UNKNOWN_ERROR |
| + |
| + if (status == SUCCESS) { |
| + UMA_HISTOGRAM_COUNTS("GCM.UnregistrationRetryNumber", |
|
fgorski
2014/05/08 18:08:36
Same comments as in Registration
jianli
2014/05/08 18:40:07
ditto.
|
| + backoff_entry_.failure_count() + 1); |
| + UMA_HISTOGRAM_TIMES("GCM.UnregistrationCompleteTime", |
| + base::TimeTicks::Now() - request_start_time_); |
| + } |
| + |
| + callback_.Run(status); |
| } |
| } // namespace gcm |